Re: [Freeipa-devel] [PATCH] 28 One Liner: Typo in host_nis_groups has been creating 2 CN's

2011-05-19 Thread Rob Crittenden

JR Aquino wrote:

On May 18, 2011, at 2:52 PM, Rob Crittenden wrote:


JR Aquino wrote:

On May 18, 2011, at 12:46 PM, JR Aquino wrote:


This effects Ticket 1222 and Rob's patch 786


Per IRC Conversation with Simo and Rob, take the path of least change.

The patch has been modified to correct the CN to match the DN rather than 
changing both.


This looks good. I'm going to wait to push it at the same time as 786.


Simo mentioned that I need to create the .update in the patch so that we remove 
the previous typo laden entry during updates.


I added that to my patch.

rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 28 One Liner: Typo in host_nis_groups has been creating 2 CN's

2011-05-18 Thread JR Aquino
On May 18, 2011, at 2:52 PM, Rob Crittenden wrote:

> JR Aquino wrote:
>> On May 18, 2011, at 12:46 PM, JR Aquino wrote:
>> 
>>> This effects Ticket 1222 and Rob's patch 786
>> 
>> Per IRC Conversation with Simo and Rob, take the path of least change.
>> 
>> The patch has been modified to correct the CN to match the DN rather than 
>> changing both.
> 
> This looks good. I'm going to wait to push it at the same time as 786.

Simo mentioned that I need to create the .update in the patch so that we remove 
the previous typo laden entry during updates.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 28 One Liner: Typo in host_nis_groups has been creating 2 CN's

2011-05-18 Thread Rob Crittenden

JR Aquino wrote:

On May 18, 2011, at 12:46 PM, JR Aquino wrote:


This effects Ticket 1222 and Rob's patch 786


Per IRC Conversation with Simo and Rob, take the path of least change.

The patch has been modified to correct the CN to match the DN rather than 
changing both.


This looks good. I'm going to wait to push it at the same time as 786.

rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 28 One Liner: Typo in host_nis_groups has been creating 2 CN's

2011-05-18 Thread JR Aquino
On May 18, 2011, at 12:46 PM, JR Aquino wrote:

> This effects Ticket 1222 and Rob's patch 786

Per IRC Conversation with Simo and Rob, take the path of least change.

The patch has been modified to correct the CN to match the DN rather than 
changing both.




binSqyGhoZYFC.bin
Description: freeipa-jraquino-0028-One-Liner-Typo-in-host_nis_groups-has-been-creating.patch
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 28 One Liner: Typo in host_nis_groups has been creating 2 CN's

2011-05-18 Thread JR Aquino
This effects Ticket 1222 and Rob's patch 786



binlDpwG7aVPN.bin
Description: freeipa-jraquino-0028-One-Liner-Typo-in-host_nis_groups-has-been-creating.patch
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel