Re: [Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label
On 07/23/2013 01:31 AM, Dmitri Pal wrote: On 07/22/2013 08:38 AM, Petr Vobornik wrote: On 07/19/2013 11:19 PM, Dmitri Pal wrote: On 07/19/2013 09:26 AM, Jan Pazdziora wrote: On Fri, Jul 19, 2013 at 03:17:49PM +0200, Petr Vobornik wrote: Disclaimer: I have no strong feelings in this matter, it just looks weird to me, so I'm OK with not doing it if it's general consensus. Originally we wanted to do this change in https://fedorahosted.org/freeipa/ticket/3569 but it was not done because of string freeze. I guess you can add field suffix to every field from /etc/password when you use it in a sentence but that doesn't necessary mean that You can. But gid exists as a concept beyond /etc/passwd. So does home directory. The GECOS field value does not, really. it's its name. man 5 passwd doesn't use word 'field' next to GECOS in fields description/list either. IMO our use case is the same. It says: GECOSThis field (sometimes called the comment field) [...] The gcos field in the password file was [...] Historically correct label would probably be 'GECOS identity' but that's not usable today as it's purpose is more general. Do we have tips in the UI? May be we should add them in future to provide extra information about meaning of the field or button. We do, but UX is not the best. 'doc' defined in .py files is displayed as a textbox tooltip. This feature is not apparent and for most of the fields the tooltip is the same as label. There is an idea to display a question mark icon next to textboxes to draw an attention to a presence of the doc text and provide it in a tooltip. I like the way how it's done in Alchemy UI: http://www.ui-alchemy.org/form You can notice there an additional information (string length limitation, example...) when field is focused. I went through open tickets and found few which touches the topic: - https://fedorahosted.org/freeipa/ticket/2912 [RFE] [Web UI] Use doc as field's tooltip instead of label * Seems to be already implemented. Then please close it and move it to the milestone where it was closed (if possible). - https://fedorahosted.org/freeipa/ticket/2413 [RFE]: add in UI examples of what is the requested field - https://fedorahosted.org/freeipa/ticket/3661 [RFE] IPA Web UI: When adding new reverse zone in DNS there could be an example of expected address format * Looks like duplicate of #2413 Right, please proceed with closing as duplicate then. I would prefer leaving only ticket 2413 open instead of changing description of 2912 though. Martin IMO we should close #2413 and maybe #2912 or change #2912 to cover the above mentioned proposals (in case of agreement). For now I think GECOS would probably be good enough. Adding field makes it more precise but looks weird. Sounds reasonable. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label
On 07/22/2013 05:33 PM, Ana Krivokapic wrote:
On 07/22/2013 09:01 AM, Martin Kosek wrote:
On 07/19/2013 11:19 PM, Dmitri Pal wrote:
On 07/19/2013 09:26 AM, Jan Pazdziora wrote:
On Fri, Jul 19, 2013 at 03:17:49PM +0200, Petr Vobornik wrote:
Disclaimer: I have no strong feelings in this matter, it just looks
weird to me, so I'm OK with not doing it if it's general consensus.
Originally we wanted to do this change in
https://fedorahosted.org/freeipa/ticket/3569 but it was not done
because of string freeze.
I guess you can add field suffix to every field from /etc/password
when you use it in a sentence but that doesn't necessary mean that
You can. But gid exists as a concept beyond /etc/passwd. So does home
directory. The GECOS field value does not, really.
it's its name. man 5 passwd doesn't use word 'field' next to GECOS
in fields description/list either. IMO our use case is the same.
It says:
GECOS This field (sometimes called the comment field)
[...]
The gcos field in the password file was
[...]
Historically correct label would probably be 'GECOS identity' but
that's not usable today as it's purpose is more general.
Do we have tips in the UI?
May be we should add them in future to provide extra information about
meaning of the field or button.
For now I think GECOS would probably be good enough.
Adding field makes it more precise but looks weird.
+1 for just GECOS. Petr showed me both variants in the UI and GECOS field
really looked weird.
Martin
+1 for removing the word 'field'. The phrase 'GECOS field' also exists in the
following files:
install/ui/test/data/ipa_init_commands.json
install/ui/test/data/ipa_init_objects.json
install/ui/test/data/json_metadata.json
So it should be fixed there as well.
Fixed.
--
Petr Vobornik
From b0965b0c6cb056655a138205e0e205f21ddb2ee4 Mon Sep 17 00:00:00 2001
From: Petr Vobornik pvobo...@redhat.com
Date: Fri, 19 Jul 2013 13:35:17 +0200
Subject: [PATCH] Remove word 'field' from GECOS param label
No other param/field has 'field' in a label.
---
install/ui/test/data/ipa_init_commands.json | 12 ++--
install/ui/test/data/ipa_init_objects.json | 4 ++--
install/ui/test/data/json_metadata.json | 4 ++--
ipalib/plugins/user.py | 2 +-
4 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/install/ui/test/data/ipa_init_commands.json b/install/ui/test/data/ipa_init_commands.json
index f83059bcdb3eefa3b254c764c5d42234f697fcfd..3a812ef5143972c1b043bf5ef41be3e7dafe1a28 100644
--- a/install/ui/test/data/ipa_init_commands.json
+++ b/install/ui/test/data/ipa_init_commands.json
@@ -16976,9 +16976,9 @@
{
attribute: true,
class: Str,
-doc: GECOS field,
+doc: GECOS,
flags: [],
-label: GECOS field,
+label: GECOS,
name: gecos,
noextrawhitespace: true,
type: unicode
@@ -17350,9 +17350,9 @@
{
attribute: true,
class: Str,
-doc: GECOS field,
+doc: GECOS,
flags: [],
-label: GECOS field,
+label: GECOS,
name: gecos,
noextrawhitespace: true,
query: true,
@@ -17807,9 +17807,9 @@
{
attribute: true,
class: Str,
-doc: GECOS field,
+doc: GECOS,
flags: [],
-label: GECOS field,
+label: GECOS,
name: gecos,
noextrawhitespace: true,
type: unicode
diff --git a/install/ui/test/data/ipa_init_objects.json b/install/ui/test/data/ipa_init_objects.json
index 5d1fd65aaa2be6e1ed346ebb6072f618db944cf6..7d8baed33a073ea7a410fd44ac486360a627d3cf 100644
--- a/install/ui/test/data/ipa_init_objects.json
+++ b/install/ui/test/data/ipa_init_objects.json
@@ -7671,9 +7671,9 @@
},
{
class: Str,
-doc: GECOS field,
+doc: GECOS,
flags: [],
-label: GECOS field,
+label: GECOS,
name: gecos,
noextrawhitespace: true,
type: unicode
diff --git a/install/ui/test/data/json_metadata.json b/install/ui/test/data/json_metadata.json
index a3febc1ff9f779f3274174a3ec2e4f46fe4b3391..928e5eafd66158ab41c40ce3f5c3b1d486cdf13f 100644
--- a/install/ui/test/data/json_metadata.json
Re: [Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label
On 07/23/2013 12:58 PM, Petr Vobornik wrote: On 07/22/2013 05:33 PM, Ana Krivokapic wrote: On 07/22/2013 09:01 AM, Martin Kosek wrote: On 07/19/2013 11:19 PM, Dmitri Pal wrote: On 07/19/2013 09:26 AM, Jan Pazdziora wrote: On Fri, Jul 19, 2013 at 03:17:49PM +0200, Petr Vobornik wrote: Disclaimer: I have no strong feelings in this matter, it just looks weird to me, so I'm OK with not doing it if it's general consensus. Originally we wanted to do this change in https://fedorahosted.org/freeipa/ticket/3569 but it was not done because of string freeze. I guess you can add field suffix to every field from /etc/password when you use it in a sentence but that doesn't necessary mean that You can. But gid exists as a concept beyond /etc/passwd. So does home directory. The GECOS field value does not, really. it's its name. man 5 passwd doesn't use word 'field' next to GECOS in fields description/list either. IMO our use case is the same. It says: GECOSThis field (sometimes called the comment field) [...] The gcos field in the password file was [...] Historically correct label would probably be 'GECOS identity' but that's not usable today as it's purpose is more general. Do we have tips in the UI? May be we should add them in future to provide extra information about meaning of the field or button. For now I think GECOS would probably be good enough. Adding field makes it more precise but looks weird. +1 for just GECOS. Petr showed me both variants in the UI and GECOS field really looked weird. Martin +1 for removing the word 'field'. The phrase 'GECOS field' also exists in the following files: install/ui/test/data/ipa_init_commands.json install/ui/test/data/ipa_init_objects.json install/ui/test/data/json_metadata.json So it should be fixed there as well. Fixed. ACK -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label
On 07/23/2013 09:02 AM, Martin Kosek wrote: On 07/23/2013 01:31 AM, Dmitri Pal wrote: On 07/22/2013 08:38 AM, Petr Vobornik wrote: On 07/19/2013 11:19 PM, Dmitri Pal wrote: On 07/19/2013 09:26 AM, Jan Pazdziora wrote: On Fri, Jul 19, 2013 at 03:17:49PM +0200, Petr Vobornik wrote: Disclaimer: I have no strong feelings in this matter, it just looks weird to me, so I'm OK with not doing it if it's general consensus. Originally we wanted to do this change in https://fedorahosted.org/freeipa/ticket/3569 but it was not done because of string freeze. I guess you can add field suffix to every field from /etc/password when you use it in a sentence but that doesn't necessary mean that You can. But gid exists as a concept beyond /etc/passwd. So does home directory. The GECOS field value does not, really. it's its name. man 5 passwd doesn't use word 'field' next to GECOS in fields description/list either. IMO our use case is the same. It says: GECOSThis field (sometimes called the comment field) [...] The gcos field in the password file was [...] Historically correct label would probably be 'GECOS identity' but that's not usable today as it's purpose is more general. Do we have tips in the UI? May be we should add them in future to provide extra information about meaning of the field or button. We do, but UX is not the best. 'doc' defined in .py files is displayed as a textbox tooltip. This feature is not apparent and for most of the fields the tooltip is the same as label. There is an idea to display a question mark icon next to textboxes to draw an attention to a presence of the doc text and provide it in a tooltip. I like the way how it's done in Alchemy UI: http://www.ui-alchemy.org/form You can notice there an additional information (string length limitation, example...) when field is focused. I went through open tickets and found few which touches the topic: - https://fedorahosted.org/freeipa/ticket/2912 [RFE] [Web UI] Use doc as field's tooltip instead of label * Seems to be already implemented. Then please close it and move it to the milestone where it was closed (if possible). - https://fedorahosted.org/freeipa/ticket/2413 [RFE]: add in UI examples of what is the requested field - https://fedorahosted.org/freeipa/ticket/3661 [RFE] IPA Web UI: When adding new reverse zone in DNS there could be an example of expected address format * Looks like duplicate of #2413 Right, please proceed with closing as duplicate then. I would prefer leaving only ticket 2413 open instead of changing description of 2912 though. Martin Resolution: * #3661, #2413 closed. * New ticket https://fedorahosted.org/freeipa/ticket/3812 for the UX enhancement. IMO we should close #2413 and maybe #2912 or change #2912 to cover the above mentioned proposals (in case of agreement). For now I think GECOS would probably be good enough. Adding field makes it more precise but looks weird. Sounds reasonable. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label
On 07/23/2013 01:12 PM, Ana Krivokapic wrote: On 07/23/2013 12:58 PM, Petr Vobornik wrote: On 07/22/2013 05:33 PM, Ana Krivokapic wrote: On 07/22/2013 09:01 AM, Martin Kosek wrote: On 07/19/2013 11:19 PM, Dmitri Pal wrote: On 07/19/2013 09:26 AM, Jan Pazdziora wrote: On Fri, Jul 19, 2013 at 03:17:49PM +0200, Petr Vobornik wrote: snip For now I think GECOS would probably be good enough. Adding field makes it more precise but looks weird. +1 for just GECOS. Petr showed me both variants in the UI and GECOS field really looked weird. +1 for removing the word 'field'. The phrase 'GECOS field' also exists in the following files: install/ui/test/data/ipa_init_commands.json install/ui/test/data/ipa_init_objects.json install/ui/test/data/json_metadata.json So it should be fixed there as well. Fixed. ACK Pushed to master. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label
On 07/19/2013 11:19 PM, Dmitri Pal wrote: On 07/19/2013 09:26 AM, Jan Pazdziora wrote: On Fri, Jul 19, 2013 at 03:17:49PM +0200, Petr Vobornik wrote: Disclaimer: I have no strong feelings in this matter, it just looks weird to me, so I'm OK with not doing it if it's general consensus. Originally we wanted to do this change in https://fedorahosted.org/freeipa/ticket/3569 but it was not done because of string freeze. I guess you can add field suffix to every field from /etc/password when you use it in a sentence but that doesn't necessary mean that You can. But gid exists as a concept beyond /etc/passwd. So does home directory. The GECOS field value does not, really. it's its name. man 5 passwd doesn't use word 'field' next to GECOS in fields description/list either. IMO our use case is the same. It says: GECOS This field (sometimes called the comment field) [...] The gcos field in the password file was [...] Historically correct label would probably be 'GECOS identity' but that's not usable today as it's purpose is more general. Do we have tips in the UI? May be we should add them in future to provide extra information about meaning of the field or button. For now I think GECOS would probably be good enough. Adding field makes it more precise but looks weird. +1 for just GECOS. Petr showed me both variants in the UI and GECOS field really looked weird. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label
On 07/19/2013 11:19 PM, Dmitri Pal wrote: On 07/19/2013 09:26 AM, Jan Pazdziora wrote: On Fri, Jul 19, 2013 at 03:17:49PM +0200, Petr Vobornik wrote: Disclaimer: I have no strong feelings in this matter, it just looks weird to me, so I'm OK with not doing it if it's general consensus. Originally we wanted to do this change in https://fedorahosted.org/freeipa/ticket/3569 but it was not done because of string freeze. I guess you can add field suffix to every field from /etc/password when you use it in a sentence but that doesn't necessary mean that You can. But gid exists as a concept beyond /etc/passwd. So does home directory. The GECOS field value does not, really. it's its name. man 5 passwd doesn't use word 'field' next to GECOS in fields description/list either. IMO our use case is the same. It says: GECOS This field (sometimes called the comment field) [...] The gcos field in the password file was [...] Historically correct label would probably be 'GECOS identity' but that's not usable today as it's purpose is more general. Do we have tips in the UI? May be we should add them in future to provide extra information about meaning of the field or button. We do, but UX is not the best. 'doc' defined in .py files is displayed as a textbox tooltip. This feature is not apparent and for most of the fields the tooltip is the same as label. There is an idea to display a question mark icon next to textboxes to draw an attention to a presence of the doc text and provide it in a tooltip. I like the way how it's done in Alchemy UI: http://www.ui-alchemy.org/form You can notice there an additional information (string length limitation, example...) when field is focused. I went through open tickets and found few which touches the topic: - https://fedorahosted.org/freeipa/ticket/2912 [RFE] [Web UI] Use doc as field's tooltip instead of label * Seems to be already implemented. - https://fedorahosted.org/freeipa/ticket/2413 [RFE]: add in UI examples of what is the requested field - https://fedorahosted.org/freeipa/ticket/3661 [RFE] IPA Web UI: When adding new reverse zone in DNS there could be an example of expected address format * Looks like duplicate of #2413 IMO we should close #2413 and maybe #2912 or change #2912 to cover the above mentioned proposals (in case of agreement). For now I think GECOS would probably be good enough. Adding field makes it more precise but looks weird. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label
On 07/22/2013 09:01 AM, Martin Kosek wrote: On 07/19/2013 11:19 PM, Dmitri Pal wrote: On 07/19/2013 09:26 AM, Jan Pazdziora wrote: On Fri, Jul 19, 2013 at 03:17:49PM +0200, Petr Vobornik wrote: Disclaimer: I have no strong feelings in this matter, it just looks weird to me, so I'm OK with not doing it if it's general consensus. Originally we wanted to do this change in https://fedorahosted.org/freeipa/ticket/3569 but it was not done because of string freeze. I guess you can add field suffix to every field from /etc/password when you use it in a sentence but that doesn't necessary mean that You can. But gid exists as a concept beyond /etc/passwd. So does home directory. The GECOS field value does not, really. it's its name. man 5 passwd doesn't use word 'field' next to GECOS in fields description/list either. IMO our use case is the same. It says: GECOS This field (sometimes called the comment field) [...] The gcos field in the password file was [...] Historically correct label would probably be 'GECOS identity' but that's not usable today as it's purpose is more general. Do we have tips in the UI? May be we should add them in future to provide extra information about meaning of the field or button. For now I think GECOS would probably be good enough. Adding field makes it more precise but looks weird. +1 for just GECOS. Petr showed me both variants in the UI and GECOS field really looked weird. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel +1 for removing the word 'field'. The phrase 'GECOS field' also exists in the following files: install/ui/test/data/ipa_init_commands.json install/ui/test/data/ipa_init_objects.json install/ui/test/data/json_metadata.json So it should be fixed there as well. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label
On 07/22/2013 08:38 AM, Petr Vobornik wrote: On 07/19/2013 11:19 PM, Dmitri Pal wrote: On 07/19/2013 09:26 AM, Jan Pazdziora wrote: On Fri, Jul 19, 2013 at 03:17:49PM +0200, Petr Vobornik wrote: Disclaimer: I have no strong feelings in this matter, it just looks weird to me, so I'm OK with not doing it if it's general consensus. Originally we wanted to do this change in https://fedorahosted.org/freeipa/ticket/3569 but it was not done because of string freeze. I guess you can add field suffix to every field from /etc/password when you use it in a sentence but that doesn't necessary mean that You can. But gid exists as a concept beyond /etc/passwd. So does home directory. The GECOS field value does not, really. it's its name. man 5 passwd doesn't use word 'field' next to GECOS in fields description/list either. IMO our use case is the same. It says: GECOSThis field (sometimes called the comment field) [...] The gcos field in the password file was [...] Historically correct label would probably be 'GECOS identity' but that's not usable today as it's purpose is more general. Do we have tips in the UI? May be we should add them in future to provide extra information about meaning of the field or button. We do, but UX is not the best. 'doc' defined in .py files is displayed as a textbox tooltip. This feature is not apparent and for most of the fields the tooltip is the same as label. There is an idea to display a question mark icon next to textboxes to draw an attention to a presence of the doc text and provide it in a tooltip. I like the way how it's done in Alchemy UI: http://www.ui-alchemy.org/form You can notice there an additional information (string length limitation, example...) when field is focused. I went through open tickets and found few which touches the topic: - https://fedorahosted.org/freeipa/ticket/2912 [RFE] [Web UI] Use doc as field's tooltip instead of label * Seems to be already implemented. - https://fedorahosted.org/freeipa/ticket/2413 [RFE]: add in UI examples of what is the requested field - https://fedorahosted.org/freeipa/ticket/3661 [RFE] IPA Web UI: When adding new reverse zone in DNS there could be an example of expected address format * Looks like duplicate of #2413 IMO we should close #2413 and maybe #2912 or change #2912 to cover the above mentioned proposals (in case of agreement). For now I think GECOS would probably be good enough. Adding field makes it more precise but looks weird. Sounds reasonable. -- Thank you, Dmitri Pal Sr. Engineering Manager for IdM portfolio Red Hat Inc. --- Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label
Remove word 'field' from GECOS param label
No other param/field has 'field' in a label.
--
Petr Vobornik
From a7f58da057c41c0902fde6b4f0c66d6ba5d5fdec Mon Sep 17 00:00:00 2001
From: Petr Vobornik pvobo...@redhat.com
Date: Fri, 19 Jul 2013 13:35:17 +0200
Subject: [PATCH] Remove word 'field' from GECOS param label
No other param/field has 'field' in a label.
---
ipalib/plugins/user.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ipalib/plugins/user.py b/ipalib/plugins/user.py
index 5d667dc94d483c2775d4a1d793624fc081615047..9087a1ba269716fb65ce7c53a95f4edfbfdcd56a 100644
--- a/ipalib/plugins/user.py
+++ b/ipalib/plugins/user.py
@@ -263,7 +263,7 @@ class user(LDAPObject):
label=_('Home directory'),
),
Str('gecos?',
-label=_('GECOS field'),
+label=_('GECOS'),
default_from=lambda givenname, sn: '%s %s' % (givenname, sn),
autofill=True,
),
--
1.8.3.1
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label
On Fri, Jul 19, 2013 at 01:44:57PM +0200, Petr Vobornik wrote: Remove word 'field' from GECOS param label No other param/field has 'field' in a label. I'm not sure I'm in favour of the change. Calling it just GECOS does not make much sense because as an informational field in /etc/passwd, it is not General Electric Comprehensive Operating System. It is the field that was (I assume) acced by/for GECOS back then but still the full name is GECOS field (of /etc/passwd). -- Jan Pazdziora | adelton at #ipa*, #brno Principal Software Engineer, Identity Management Engineering, Red Hat ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label
On 07/19/2013 02:20 PM, Jan Pazdziora wrote: On Fri, Jul 19, 2013 at 01:44:57PM +0200, Petr Vobornik wrote: Remove word 'field' from GECOS param label No other param/field has 'field' in a label. I'm not sure I'm in favour of the change. Calling it just GECOS does not make much sense because as an informational field in /etc/passwd, it is not General Electric Comprehensive Operating System. It is the field that was (I assume) acced by/for GECOS back then but still the full name is GECOS field (of /etc/passwd). Disclaimer: I have no strong feelings in this matter, it just looks weird to me, so I'm OK with not doing it if it's general consensus. Originally we wanted to do this change in https://fedorahosted.org/freeipa/ticket/3569 but it was not done because of string freeze. I guess you can add field suffix to every field from /etc/password when you use it in a sentence but that doesn't necessary mean that it's its name. man 5 passwd doesn't use word 'field' next to GECOS in fields description/list either. IMO our use case is the same. Historically correct label would probably be 'GECOS identity' but that's not usable today as it's purpose is more general. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label
On Fri, Jul 19, 2013 at 03:17:49PM +0200, Petr Vobornik wrote: Disclaimer: I have no strong feelings in this matter, it just looks weird to me, so I'm OK with not doing it if it's general consensus. Originally we wanted to do this change in https://fedorahosted.org/freeipa/ticket/3569 but it was not done because of string freeze. I guess you can add field suffix to every field from /etc/password when you use it in a sentence but that doesn't necessary mean that You can. But gid exists as a concept beyond /etc/passwd. So does home directory. The GECOS field value does not, really. it's its name. man 5 passwd doesn't use word 'field' next to GECOS in fields description/list either. IMO our use case is the same. It says: GECOS This field (sometimes called the comment field) [...] The gcos field in the password file was [...] Historically correct label would probably be 'GECOS identity' but that's not usable today as it's purpose is more general. -- Jan Pazdziora | adelton at #ipa*, #brno Principal Software Engineer, Identity Management Engineering, Red Hat ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label
On 07/19/2013 09:26 AM, Jan Pazdziora wrote: On Fri, Jul 19, 2013 at 03:17:49PM +0200, Petr Vobornik wrote: Disclaimer: I have no strong feelings in this matter, it just looks weird to me, so I'm OK with not doing it if it's general consensus. Originally we wanted to do this change in https://fedorahosted.org/freeipa/ticket/3569 but it was not done because of string freeze. I guess you can add field suffix to every field from /etc/password when you use it in a sentence but that doesn't necessary mean that You can. But gid exists as a concept beyond /etc/passwd. So does home directory. The GECOS field value does not, really. it's its name. man 5 passwd doesn't use word 'field' next to GECOS in fields description/list either. IMO our use case is the same. It says: GECOS This field (sometimes called the comment field) [...] The gcos field in the password file was [...] Historically correct label would probably be 'GECOS identity' but that's not usable today as it's purpose is more general. Do we have tips in the UI? May be we should add them in future to provide extra information about meaning of the field or button. For now I think GECOS would probably be good enough. Adding field makes it more precise but looks weird. -- Thank you, Dmitri Pal Sr. Engineering Manager for IdM portfolio Red Hat Inc. --- Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
