Re: [Freeipa-devel] [PATCH] 564 webui-ci: fix test_rebuild_membership_hosts on server without DNS

2014-03-24 Thread Martin Kosek
On 03/21/2014 03:17 PM, Petr Vobornik wrote:
 Host adder dialog differs on installations with and without DNS.
 Previous test used values for adding hosts which were suitable only for IPA
 servers installed with DNS.

Thanks for the fix. It looks OK and should fix the CI failure I was seeing.

ACK. Pushed to master.

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


[Freeipa-devel] [PATCH] 564 webui-ci: fix test_rebuild_membership_hosts on server without DNS

2014-03-21 Thread Petr Vobornik

Host adder dialog differs on installations with and without DNS.
Previous test used values for adding hosts which were suitable only for 
IPA servers installed with DNS.

--
Petr Vobornik
From 9ca559347b4f233772b2179da725eb28bddbe4e2 Mon Sep 17 00:00:00 2001
From: Petr Vobornik pvobo...@redhat.com
Date: Fri, 21 Mar 2014 15:01:24 +0100
Subject: [PATCH] webui-ci: fix test_rebuild_membership_hosts on server without
 DNS

Host adder dialog differs on installations with and without DNS.
Previous test used values for adding hosts which were suitable only for IPA servers installed with DNS.
---
 ipatests/test_webui/test_automember.py | 24 +---
 1 file changed, 5 insertions(+), 19 deletions(-)

diff --git a/ipatests/test_webui/test_automember.py b/ipatests/test_webui/test_automember.py
index 93cebeb40301558b7237f5ed6524652825a12e57..57cc7c989f9a3e012a609030fc047e24fcf1c6c3 100644
--- a/ipatests/test_webui/test_automember.py
+++ b/ipatests/test_webui/test_automember.py
@@ -23,6 +23,7 @@ Automember tests
 
 from ipatests.test_webui.ui_driver import UI_driver
 import ipatests.test_webui.data_hostgroup as hostgroup
+from ipatests.test_webui.test_host import host_tasks
 
 ENTITY = 'automember'
 
@@ -88,6 +89,7 @@ class test_automember(UI_driver):
 
 self.init_app()
 
+host_util = host_tasks()
 domain = self.config.get('ipa_domain')
 host1 = 'web1.%s' % domain
 host2 = 'web2.%s' % domain
@@ -101,25 +103,9 @@ class test_automember(UI_driver):
 ]
 })
 
-# Add a host
-self.add_record('host', {
-'pkey': host1,
-'add': [
-('textbox', 'hostname', 'web1'),
-('combobox', 'dnszone', domain),
-('checkbox', 'force', 'checked'),
-]
-})
-
-# Add another host
-self.add_record('host', {
-'pkey': host2,
-'add': [
-('textbox', 'hostname', 'web2'),
-('combobox', 'dnszone', domain),
-('checkbox', 'force', 'checked'),
-]
-})
+# Add hosts
+self.add_record('host', host_util.get_data(web1, domain));
+self.add_record('host', host_util.get_data(web2, domain));
 
 # Add an automember rule
 self.add_record(
-- 
1.8.5.3

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel