Re: [Freeipa-devel] [PATCH] 73 Update config doc to reflect that 0 is not allowed for search time limit.
David O'Brien wrote:
Pavel Zuna wrote:
On 02/08/2011 12:34 AM, David O'Brien wrote:
Pavel Zuna wrote:
Fix #837
Pavel
/me hesitantly asks...
Doesn't this mean that "1" is illegal?
doc=_('Max. amount of time (sec.) for a search (> 1 or -1 for
unlimited)'),
Neither is there any mention of zero being illegal. It may be implicit
or self-evident, but I don't rely on that in doc. I'd be inclined to
change it to (> 0, or -1 for unlimited) but remember, I'm not a coder :)
cheers
You're right. :)
Fixed version attached.
Pavel
my ACK
Fine with me too, pushed to master
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 73 Update config doc to reflect that 0 is not allowed for search time limit.
Pavel Zuna wrote:
On 02/08/2011 12:34 AM, David O'Brien wrote:
Pavel Zuna wrote:
Fix #837
Pavel
/me hesitantly asks...
Doesn't this mean that "1" is illegal?
doc=_('Max. amount of time (sec.) for a search (> 1 or -1 for
unlimited)'),
Neither is there any mention of zero being illegal. It may be implicit
or self-evident, but I don't rely on that in doc. I'd be inclined to
change it to (> 0, or -1 for unlimited) but remember, I'm not a coder :)
cheers
You're right. :)
Fixed version attached.
Pavel
my ACK
--
David O'Brien
Red Hat Asia Pacific Pty Ltd
+61 7 3514 8189
"He who asks is a fool for five minutes, but he who does not ask remains
a fool forever."
~ Chinese proverb
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 73 Update config doc to reflect that 0 is not allowed for search time limit.
On 02/08/2011 12:34 AM, David O'Brien wrote:
Pavel Zuna wrote:
Fix #837
Pavel
/me hesitantly asks...
Doesn't this mean that "1" is illegal?
doc=_('Max. amount of time (sec.) for a search (> 1 or -1 for unlimited)'),
Neither is there any mention of zero being illegal. It may be implicit
or self-evident, but I don't rely on that in doc. I'd be inclined to
change it to (> 0, or -1 for unlimited) but remember, I'm not a coder :)
cheers
You're right. :)
Fixed version attached.
Pavel
freeipa-pzuna-73-2-configdoc.patch
Description: application/mbox
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 73 Update config doc to reflect that 0 is not allowed for search time limit.
Pavel Zuna wrote:
Fix #837
Pavel
/me hesitantly asks...
Doesn't this mean that "1" is illegal?
doc=_('Max. amount of time (sec.) for a search (> 1 or -1 for unlimited)'),
Neither is there any mention of zero being illegal. It may be implicit
or self-evident, but I don't rely on that in doc. I'd be inclined to
change it to (> 0, or -1 for unlimited) but remember, I'm not a coder :)
cheers
--
David O'Brien
Red Hat Asia Pacific Pty Ltd
+61 7 3514 8189
"He who asks is a fool for five minutes, but he who does not ask remains
a fool forever."
~ Chinese proverb
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 73 Update config doc to reflect that 0 is not allowed for search time limit.
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/07/2011 12:47 PM, Pavel Zuna wrote: > Fix #837 > > Pavel > Ack -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk1P5RcACgkQHsardTLnvCX8ZACgo6Q/1rjYnKJHLnK/hmsHCZZs ze4AoIXTQ1TyeOqxdE4jz83F/c2keFzt =3hgs -END PGP SIGNATURE- ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH] 73 Update config doc to reflect that 0 is not allowed for search time limit.
Fix #837 Pavel freeipa-pzuna-73-configdoc.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
