Re: [Freeipa-devel] [PATCH] 990 attribute name in exceptions

2012-03-20 Thread Martin Kosek
On Mon, 2012-03-19 at 15:41 -0400, Rob Crittenden wrote: > Martin Kosek wrote: > > On Mon, 2012-03-19 at 14:43 -0400, Rob Crittenden wrote: > >> Petr Viktorin wrote: > >>> On 03/19/2012 03:02 PM, Rob Crittenden wrote: > Petr Viktorin wrote: > > On 03/16/2012 10:23 PM, Rob Crittenden wrote:

Re: [Freeipa-devel] [PATCH] 990 attribute name in exceptions

2012-03-19 Thread Rob Crittenden
Martin Kosek wrote: On Mon, 2012-03-19 at 14:43 -0400, Rob Crittenden wrote: Petr Viktorin wrote: On 03/19/2012 03:02 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 03/16/2012 10:23 PM, Rob Crittenden wrote: When using *attr we should return the param.name of in the exception and when usi

Re: [Freeipa-devel] [PATCH] 990 attribute name in exceptions

2012-03-19 Thread Martin Kosek
On Mon, 2012-03-19 at 14:43 -0400, Rob Crittenden wrote: > Petr Viktorin wrote: > > On 03/19/2012 03:02 PM, Rob Crittenden wrote: > >> Petr Viktorin wrote: > >>> On 03/16/2012 10:23 PM, Rob Crittenden wrote: > When using *attr we should return the param.name of in the exception > and > >>

Re: [Freeipa-devel] [PATCH] 990 attribute name in exceptions

2012-03-19 Thread Rob Crittenden
Petr Viktorin wrote: On 03/19/2012 03:02 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 03/16/2012 10:23 PM, Rob Crittenden wrote: When using *attr we should return the param.name of in the exception and when using a cli option we should return param.cli_name. This didn't work consistently

Re: [Freeipa-devel] [PATCH] 990 attribute name in exceptions

2012-03-19 Thread Petr Viktorin
On 03/19/2012 03:02 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 03/16/2012 10:23 PM, Rob Crittenden wrote: When using *attr we should return the param.name of in the exception and when using a cli option we should return param.cli_name. This didn't work consistently in the framework. Thi

Re: [Freeipa-devel] [PATCH] 990 attribute name in exceptions

2012-03-19 Thread Rob Crittenden
Petr Viktorin wrote: On 03/16/2012 10:23 PM, Rob Crittenden wrote: When using *attr we should return the param.name of in the exception and when using a cli option we should return param.cli_name. This didn't work consistently in the framework. This is a bit of a kludge, catching exceptions and

Re: [Freeipa-devel] [PATCH] 990 attribute name in exceptions

2012-03-19 Thread Petr Viktorin
On 03/16/2012 10:23 PM, Rob Crittenden wrote: When using *attr we should return the param.name of in the exception and when using a cli option we should return param.cli_name. This didn't work consistently in the framework. This is a bit of a kludge, catching exceptions and re-raising them, but

[Freeipa-devel] [PATCH] 990 attribute name in exceptions

2012-03-16 Thread Rob Crittenden
When using *attr we should return the param.name of in the exception and when using a cli option we should return param.cli_name. This didn't work consistently in the framework. This is a bit of a kludge, catching exceptions and re-raising them, but it is a less invasive way of doing it. I a