[Freeipa-devel] [PATCH] BuildRequires: rhino in .spec file

2014-03-14 Thread Nalin Dahyabhai
When I try to scratch build master using 'make srpm' and koji, the build
log includes multiple errors like this:
  ../../util/make-ui.sh
  Error: Could not find or load main class 
org.mozilla.javascript.tools.shell.Main
  Error: Could not find or load main class 
org.mozilla.javascript.tools.shell.Main
  Error: Could not find or load main class 
org.mozilla.javascript.tools.shell.Main

Those classes are provided by the 'rhino' package in Raw Hide, so I
suggest adding it as a build-time requirement.

Nalin
From b8b146c09c9c77105f4f48743cd6d59ca6903f16 Mon Sep 17 00:00:00 2001
From: Nalin Dahyabhai na...@dahyabhai.net
Date: Thu, 13 Mar 2014 17:09:49 -0400
Subject: [PATCH] Add missing dependency

We use Java classes which are bundled with rhino when uglifying
Javascript sources at build-time, so we need rhino at build-time.
---
 freeipa.spec.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/freeipa.spec.in b/freeipa.spec.in
index e851313..c17e939 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -74,6 +74,7 @@ BuildRequires:  check
 BuildRequires:  libsss_idmap-devel
 BuildRequires:  libsss_nss_idmap-devel
 BuildRequires:  java-1.7.0-openjdk
+BuildRequires:  rhino
 BuildRequires:  libverto-devel
 BuildRequires:  systemd
 BuildRequires:  libunistring-devel
-- 
1.9.0

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] BuildRequires: rhino in .spec file

2014-03-14 Thread Petr Vobornik

On 14.3.2014 14:20, Nalin Dahyabhai wrote:

When I try to scratch build master using 'make srpm' and koji, the build
log includes multiple errors like this:
   ../../util/make-ui.sh
   Error: Could not find or load main class 
org.mozilla.javascript.tools.shell.Main
   Error: Could not find or load main class 
org.mozilla.javascript.tools.shell.Main
   Error: Could not find or load main class 
org.mozilla.javascript.tools.shell.Main

Those classes are provided by the 'rhino' package in Raw Hide, so I
suggest adding it as a build-time requirement.

Nalin



ACK

java-1.7.0-opnjdk no longer pulls rhino. Caused by:
http://pkgs.fedoraproject.org/cgit/java-1.7.0-openjdk.git/commit/?id=63ecc0b8d60970f6d1d80f822cebf78441beb56a
--
Petr Vobornik

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] BuildRequires: rhino in .spec file

2014-03-14 Thread Petr Vobornik

On 14.3.2014 14:50, Petr Vobornik wrote:

On 14.3.2014 14:20, Nalin Dahyabhai wrote:

When I try to scratch build master using 'make srpm' and koji, the build
log includes multiple errors like this:
   ../../util/make-ui.sh
   Error: Could not find or load main class
org.mozilla.javascript.tools.shell.Main
   Error: Could not find or load main class
org.mozilla.javascript.tools.shell.Main
   Error: Could not find or load main class
org.mozilla.javascript.tools.shell.Main

Those classes are provided by the 'rhino' package in Raw Hide, so I
suggest adding it as a build-time requirement.

Nalin



ACK

java-1.7.0-opnjdk no longer pulls rhino. Caused by:
http://pkgs.fedoraproject.org/cgit/java-1.7.0-openjdk.git/commit/?id=63ecc0b8d60970f6d1d80f822cebf78441beb56a



Pushed to master: 35b7c1d909adb1d36bcfd4b3ba8993d5c1ed1a14
--
Petr Vobornik

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel