Re: [Freeipa-devel] [PATCH] SPEC: Remove unused build dependency on libwbclient
On 09.03.2016 11:57, Sumit Bose wrote: On Wed, Mar 09, 2016 at 09:59:06AM +0100, Lukas Slebodnik wrote: ehlo, simple patch is attached. LS >From 3fe91e54c11245c3a773bc2cff5504b7a5f6ad16 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Wed, 9 Mar 2016 09:53:07 +0100 Subject: [PATCH] SPEC: Remove unused build dependency on libwbclient The string "wbclient" is not mentioned anywhere in source code and there isn't any issue with building freeipa packages without this package. ACK This is a left-over form the times where we used winbind to look up AD users. With the ipa server mode of SSSD this is not needed anymore. bye, Sumit Pushed to master: 2a61ddb644b4a0bee37c1faf82c461b4cf41bc38 --- BUILD.txt | 2 +- freeipa.spec.in | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/BUILD.txt b/BUILD.txt index fb1a7996b6b0c69c5431b180eec65c2549448d91..d9484956dc4449fa43ff0a1146ca9cdf5b3e021e 100644 --- a/BUILD.txt +++ b/BUILD.txt @@ -16,7 +16,7 @@ or This is currently (2015-05-07): yum install rpm-build 389-ds-base-devel svrcore-devel policycoreutils \ -systemd-units samba-devel samba-python libwbclient-devel libtalloc-devel \ +systemd-units samba-devel samba-python libtalloc-devel \ libtevent-devel nspr-devel nss-devel openssl-devel openldap-devel krb5-devel \ krb5-workstation libuuid-devel libcurl-devel xmlrpc-c-devel popt-devel \ autoconf automake m4 libtool gettext python-devel python-ldap \ diff --git a/freeipa.spec.in b/freeipa.spec.in index bc47df4c916bd8f091fc2f70330d95bd116ad187..9e277020d70215e052ab6c905b1c6a29ae6cdd4d 100644 --- a/freeipa.spec.in +++ b/freeipa.spec.in @@ -48,7 +48,6 @@ BuildRequires: policycoreutils >= 2.1.12-5 BuildRequires: systemd-units BuildRequires: samba-devel >= %{samba_version} BuildRequires: samba-python -BuildRequires: libwbclient-devel BuildRequires: libtalloc-devel BuildRequires: libtevent-devel %endif # ONLY_CLIENT -- 2.7.2 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH] SPEC: Remove unused build dependency on libwbclient
On Wed, Mar 09, 2016 at 09:59:06AM +0100, Lukas Slebodnik wrote: > ehlo, > > simple patch is attached. > > LS > >From 3fe91e54c11245c3a773bc2cff5504b7a5f6ad16 Mon Sep 17 00:00:00 2001 > From: Lukas Slebodnik > Date: Wed, 9 Mar 2016 09:53:07 +0100 > Subject: [PATCH] SPEC: Remove unused build dependency on libwbclient > > The string "wbclient" is not mentioned anywhere in > source code and there isn't any issue with building > freeipa packages without this package. ACK This is a left-over form the times where we used winbind to look up AD users. With the ipa server mode of SSSD this is not needed anymore. bye, Sumit > --- > BUILD.txt | 2 +- > freeipa.spec.in | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/BUILD.txt b/BUILD.txt > index > fb1a7996b6b0c69c5431b180eec65c2549448d91..d9484956dc4449fa43ff0a1146ca9cdf5b3e021e > 100644 > --- a/BUILD.txt > +++ b/BUILD.txt > @@ -16,7 +16,7 @@ or > This is currently (2015-05-07): > > yum install rpm-build 389-ds-base-devel svrcore-devel policycoreutils \ > -systemd-units samba-devel samba-python libwbclient-devel libtalloc-devel \ > +systemd-units samba-devel samba-python libtalloc-devel \ > libtevent-devel nspr-devel nss-devel openssl-devel openldap-devel krb5-devel > \ > krb5-workstation libuuid-devel libcurl-devel xmlrpc-c-devel popt-devel \ > autoconf automake m4 libtool gettext python-devel python-ldap \ > diff --git a/freeipa.spec.in b/freeipa.spec.in > index > bc47df4c916bd8f091fc2f70330d95bd116ad187..9e277020d70215e052ab6c905b1c6a29ae6cdd4d > 100644 > --- a/freeipa.spec.in > +++ b/freeipa.spec.in > @@ -48,7 +48,6 @@ BuildRequires: policycoreutils >= 2.1.12-5 > BuildRequires: systemd-units > BuildRequires: samba-devel >= %{samba_version} > BuildRequires: samba-python > -BuildRequires: libwbclient-devel > BuildRequires: libtalloc-devel > BuildRequires: libtevent-devel > %endif # ONLY_CLIENT > -- > 2.7.2 > > -- > Manage your subscription for the Freeipa-devel mailing list: > https://www.redhat.com/mailman/listinfo/freeipa-devel > Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [PATCH] SPEC: Remove unused build dependency on libwbclient
ehlo, simple patch is attached. LS >From 3fe91e54c11245c3a773bc2cff5504b7a5f6ad16 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Wed, 9 Mar 2016 09:53:07 +0100 Subject: [PATCH] SPEC: Remove unused build dependency on libwbclient The string "wbclient" is not mentioned anywhere in source code and there isn't any issue with building freeipa packages without this package. --- BUILD.txt | 2 +- freeipa.spec.in | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/BUILD.txt b/BUILD.txt index fb1a7996b6b0c69c5431b180eec65c2549448d91..d9484956dc4449fa43ff0a1146ca9cdf5b3e021e 100644 --- a/BUILD.txt +++ b/BUILD.txt @@ -16,7 +16,7 @@ or This is currently (2015-05-07): yum install rpm-build 389-ds-base-devel svrcore-devel policycoreutils \ -systemd-units samba-devel samba-python libwbclient-devel libtalloc-devel \ +systemd-units samba-devel samba-python libtalloc-devel \ libtevent-devel nspr-devel nss-devel openssl-devel openldap-devel krb5-devel \ krb5-workstation libuuid-devel libcurl-devel xmlrpc-c-devel popt-devel \ autoconf automake m4 libtool gettext python-devel python-ldap \ diff --git a/freeipa.spec.in b/freeipa.spec.in index bc47df4c916bd8f091fc2f70330d95bd116ad187..9e277020d70215e052ab6c905b1c6a29ae6cdd4d 100644 --- a/freeipa.spec.in +++ b/freeipa.spec.in @@ -48,7 +48,6 @@ BuildRequires: policycoreutils >= 2.1.12-5 BuildRequires: systemd-units BuildRequires: samba-devel >= %{samba_version} BuildRequires: samba-python -BuildRequires: libwbclient-devel BuildRequires: libtalloc-devel BuildRequires: libtevent-devel %endif # ONLY_CLIENT -- 2.7.2 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code