Re: [Freeipa-devel] [PATCH] webui test: bunch of patches which fix webui patches

2016-07-27 Thread Martin Basti 



On 27.07.2016 17:40, Lenka Doudova wrote:




On 07/27/2016 03:00 PM, Lenka Doudova wrote:




On 07/20/2016 04:43 PM, Pavel Vomacka wrote:




On 07/11/2016 06:33 PM, Pavel Vomacka wrote:

Hello,

please review these patches. First four of them fixes patches and 
the last one fixes small bug in WebUI which causes that some tests 
fail.


https://fedorahosted.org/freeipa/ticket/6050

https://fedorahosted.org/freeipa/ticket/6052

https://fedorahosted.org/freeipa/ticket/6053

https://fedorahosted.org/freeipa/ticket/6054




4 patches have incorrect information about user who makes the patch. 
Sending new patches which correct it.


--
Pavel^3 Vomacka



Hi,
thanks for patches, ACK on all.

Lenka


When pushing, please don't forget to push patch 0073 from the original 
email.

Lenka



master:
* 3ba3080dfe8a69d8f9e4b2cafc309853e74da9b3 Close host adder dialog 
before showing 4304 dialog
* 8c07568c0be0a2d6a54a39f868bc90b64c507f9f Remove navigation using 
breadcrumb menus

* 9f94a5f7badcec412d695914f6405f74e5b353d7 Fix test_navigation tests
* 73ef15ccb49671f0fd401018e68675e16f674bd3 Fix test which checks 
removing of user
* 41ace68e0420fc731c0005ee01a839bc6a7fd995 Set default delete action 
name to 'delete'




-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] webui test: bunch of patches which fix webui patches

2016-07-27 Thread Lenka Doudova 



On 07/27/2016 03:00 PM, Lenka Doudova wrote:




On 07/20/2016 04:43 PM, Pavel Vomacka wrote:




On 07/11/2016 06:33 PM, Pavel Vomacka wrote:

Hello,

please review these patches. First four of them fixes patches and 
the last one fixes small bug in WebUI which causes that some tests 
fail.


https://fedorahosted.org/freeipa/ticket/6050

https://fedorahosted.org/freeipa/ticket/6052

https://fedorahosted.org/freeipa/ticket/6053

https://fedorahosted.org/freeipa/ticket/6054




4 patches have incorrect information about user who makes the patch. 
Sending new patches which correct it.


--
Pavel^3 Vomacka



Hi,
thanks for patches, ACK on all.

Lenka


When pushing, please don't forget to push patch 0073 from the original 
email.

Lenka
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] webui test: bunch of patches which fix webui patches

2016-07-27 Thread Lenka Doudova 



On 07/20/2016 04:43 PM, Pavel Vomacka wrote:




On 07/11/2016 06:33 PM, Pavel Vomacka wrote:

Hello,

please review these patches. First four of them fixes patches and the 
last one fixes small bug in WebUI which causes that some tests fail.


https://fedorahosted.org/freeipa/ticket/6050

https://fedorahosted.org/freeipa/ticket/6052

https://fedorahosted.org/freeipa/ticket/6053

https://fedorahosted.org/freeipa/ticket/6054




4 patches have incorrect information about user who makes the patch. 
Sending new patches which correct it.


--
Pavel^3 Vomacka



Hi,
thanks for patches, ACK on all.

Lenka
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] webui test: bunch of patches which fix webui patches

2016-07-20 Thread Pavel Vomacka 



On 07/11/2016 06:33 PM, Pavel Vomacka wrote:

Hello,

please review these patches. First four of them fixes patches and the 
last one fixes small bug in WebUI which causes that some tests fail.


https://fedorahosted.org/freeipa/ticket/6050

https://fedorahosted.org/freeipa/ticket/6052

https://fedorahosted.org/freeipa/ticket/6053

https://fedorahosted.org/freeipa/ticket/6054




4 patches have incorrect information about user who makes the patch. 
Sending new patches which correct it.


--
Pavel^3 Vomacka

From 411f99e6ba9e2f811d8e4408eedd3399c2d89275 Mon Sep 17 00:00:00 2001
From: Pavel Vomacka 
Date: Wed, 20 Jul 2016 16:13:29 +0200
Subject: [PATCH 1/9] Remove navigation using breadcrumb menus

https://fedorahosted.org/freeipa/ticket/6054
---
 ipatests/test_webui/test_automember.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/ipatests/test_webui/test_automember.py b/ipatests/test_webui/test_automember.py
index 9f3da1e9693ec8f8a924b9e81545161eb2af44c9..5b07849b82b09177093a5bfeaa11780af419ac3c 100644
--- a/ipatests/test_webui/test_automember.py
+++ b/ipatests/test_webui/test_automember.py
@@ -159,7 +159,6 @@ class test_automember(UI_driver):
 
 # Rebuild membership for all hosts, using action on hosts search facet
 self.navigate_by_menu('identity/host')
-self.navigate_by_breadcrumb('Hosts')
 self.action_list_action('automember_rebuild')
 
 # Assert that hosts are now members of hostgroup
@@ -256,8 +255,7 @@ class test_automember(UI_driver):
 self.assert_record('dev2', negative=True)
 
 # Rebuild membership for all users, using action on users search facet
-self.navigate_by_menu('identity/user')
-self.navigate_by_breadcrumb('Users')
+self.navigate_by_menu('identity/user_search')
 self.action_list_action('automember_rebuild')
 
 # Assert that users are now members of group
-- 
2.5.5

From 00e0d44ba47df679cd8b70c7b92052d5ff915ad9 Mon Sep 17 00:00:00 2001
From: Pavel Vomacka 
Date: Wed, 20 Jul 2016 16:14:16 +0200
Subject: [PATCH 2/9] Fix test_navigation tests

Some menu item names has changed. This commit sets the correct names.

https://fedorahosted.org/freeipa/ticket/6053
---
 ipatests/test_webui/test_navigation.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ipatests/test_webui/test_navigation.py b/ipatests/test_webui/test_navigation.py
index b5dc928ac4d631fb1fc8f9ea4b0d7ddbc213e5dc..b51d71d03caa3f7f0f5abfc0939e9b41cd471037 100644
--- a/ipatests/test_webui/test_navigation.py
+++ b/ipatests/test_webui/test_navigation.py
@@ -107,7 +107,7 @@ class test_navigation(UI_driver):
 # Identity
 # don't start by users (default)
 self.navigate_by_menu('identity/group', False)
-self.navigate_by_menu('identity/user', False)
+self.navigate_by_menu('identity/user_search', False)
 self.navigate_by_menu('identity/host', False)
 self.navigate_by_menu('identity/hostgroup', False)
 self.navigate_by_menu('identity/netgroup', False)
@@ -136,9 +136,9 @@ class test_navigation(UI_driver):
 self.navigate_by_menu('authentication/radiusproxy', False)
 self.navigate_by_menu('authentication/otptoken', False)
 if self.has_ca():
-self.navigate_by_menu('authentication/cert', False)
+self.navigate_by_menu('authentication/cert_search', False)
 else:
-self.assert_menu_item('authentication/cert', False)
+self.assert_menu_item('authentication/cert_search', False)
 
 # Network Services
 self.navigate_by_menu('network_services')
-- 
2.5.5

From b39224afcf9b9d69c8823d7a0622dc78c40e81a5 Mon Sep 17 00:00:00 2001
From: Pavel Vomacka 
Date: Wed, 20 Jul 2016 16:15:07 +0200
Subject: [PATCH 3/9] Fix test which checks removing of user

The name of delete action is now 'delete_active_user' not just 'delete' therefore
tests needs to be fixed.

https://fedorahosted.org/freeipa/ticket/6052
---
 ipatests/test_webui/test_user.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipatests/test_webui/test_user.py b/ipatests/test_webui/test_user.py
index 5b509d18ca9a0738af1595678fd56ba57d405079..e926c22123ab449db2c3c061e500fa6e137d875d 100644
--- a/ipatests/test_webui/test_user.py
+++ b/ipatests/test_webui/test_user.py
@@ -161,7 +161,7 @@ class test_user(UI_driver):
 self.action_list_action('unlock')
 
 # delete
-self.delete_action(user.ENTITY, user.PKEY)
+self.delete_action(user.ENTITY, user.PKEY, action='delete_active_user')
 
 @screenshot
 def test_password_expiration_notification(self):
-- 
2.5.5

From 050cb5e6f9f87f360a2a32562b1a83e9b3c0cedf Mon Sep 17 00:00:00 2001
From: Pavel Vomacka 
Date: Wed, 20 Jul 2016 16:15:34 +0200
Subject: [PATCH 4/9] Set default delete action name to 'delete'

Only specific delete

[Freeipa-devel] [PATCH] webui test: bunch of patches which fix webui patches

2016-07-11 Thread Pavel Vomacka 

Hello,

please review these patches. First four of them fixes patches and the 
last one fixes small bug in WebUI which causes that some tests fail.


https://fedorahosted.org/freeipa/ticket/6050

https://fedorahosted.org/freeipa/ticket/6052

https://fedorahosted.org/freeipa/ticket/6053

https://fedorahosted.org/freeipa/ticket/6054


--
Pavel^3 Vomacka

From 1f2bd1df86a27e732dd5414c4649d4a4a7f98eb8 Mon Sep 17 00:00:00 2001
From: Pavel Vomacka 
Date: Mon, 11 Jul 2016 14:39:54 +0200
Subject: [PATCH 1/5] Close host adder dialog before showing 4304 dialog

The adder dialog window stayed opened but not visible. This patch closes it.

https://fedorahosted.org/freeipa/ticket/6050
---
 install/ui/src/freeipa/rpc.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/install/ui/src/freeipa/rpc.js b/install/ui/src/freeipa/rpc.js
index a185585f4176658e299e7e92434522c936cc36b4..f538e103352b0605518548f94fb9199f874da625 100644
--- a/install/ui/src/freeipa/rpc.js
+++ b/install/ui/src/freeipa/rpc.js
@@ -976,6 +976,7 @@ rpc.create_4304_error_handler = function(adder_dialog) {
 var dialog = null;
 
 if (data && data.error && data.error.code === 4304) {
+adder_dialog.close();
 dialog = IPA.message_dialog({
 name: 'error_4304_info',
 message: data.error.message,
-- 
2.5.5

From 7075ffb548d197b0c00ecdd5702a600a4d47c3ac Mon Sep 17 00:00:00 2001
From: tester 
Date: Mon, 11 Jul 2016 16:14:44 +0200
Subject: [PATCH 3/5] Fix test_navigation tests

Some menu item names has changed. This commit sets the correct names.

https://fedorahosted.org/freeipa/ticket/6053
---
 ipatests/test_webui/test_navigation.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ipatests/test_webui/test_navigation.py b/ipatests/test_webui/test_navigation.py
index b5dc928ac4d631fb1fc8f9ea4b0d7ddbc213e5dc..b51d71d03caa3f7f0f5abfc0939e9b41cd471037 100644
--- a/ipatests/test_webui/test_navigation.py
+++ b/ipatests/test_webui/test_navigation.py
@@ -107,7 +107,7 @@ class test_navigation(UI_driver):
 # Identity
 # don't start by users (default)
 self.navigate_by_menu('identity/group', False)
-self.navigate_by_menu('identity/user', False)
+self.navigate_by_menu('identity/user_search', False)
 self.navigate_by_menu('identity/host', False)
 self.navigate_by_menu('identity/hostgroup', False)
 self.navigate_by_menu('identity/netgroup', False)
@@ -136,9 +136,9 @@ class test_navigation(UI_driver):
 self.navigate_by_menu('authentication/radiusproxy', False)
 self.navigate_by_menu('authentication/otptoken', False)
 if self.has_ca():
-self.navigate_by_menu('authentication/cert', False)
+self.navigate_by_menu('authentication/cert_search', False)
 else:
-self.assert_menu_item('authentication/cert', False)
+self.assert_menu_item('authentication/cert_search', False)
 
 # Network Services
 self.navigate_by_menu('network_services')
-- 
2.5.5

From 69e5d07d40927ca28ac432c35888d2338d78d6ea Mon Sep 17 00:00:00 2001
From: tester 
Date: Mon, 11 Jul 2016 16:16:09 +0200
Subject: [PATCH 4/5] Fix test which checks removing of user

The name of delete action is now 'delete_active_user' not just 'delete' therefore
tests needs to be fixed.

https://fedorahosted.org/freeipa/ticket/6052
---
 ipatests/test_webui/test_user.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipatests/test_webui/test_user.py b/ipatests/test_webui/test_user.py
index 5b509d18ca9a0738af1595678fd56ba57d405079..e926c22123ab449db2c3c061e500fa6e137d875d 100644
--- a/ipatests/test_webui/test_user.py
+++ b/ipatests/test_webui/test_user.py
@@ -161,7 +161,7 @@ class test_user(UI_driver):
 self.action_list_action('unlock')
 
 # delete
-self.delete_action(user.ENTITY, user.PKEY)
+self.delete_action(user.ENTITY, user.PKEY, action='delete_active_user')
 
 @screenshot
 def test_password_expiration_notification(self):
-- 
2.5.5

From 185b0ed54b9a476002860c6902503745fabec378 Mon Sep 17 00:00:00 2001
From: tester 
Date: Mon, 11 Jul 2016 16:17:30 +0200
Subject: [PATCH 5/5] Set default delete action name to 'delete'

Only specific delete actions will be explicitely set.

Part of: https://fedorahosted.org/freeipa/ticket/6052
---
 ipatests/test_webui/ui_driver.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/ipatests/test_webui/ui_driver.py b/ipatests/test_webui/ui_driver.py
index 40cdad3c794a98f5f1648d3338b917084db2e3ed..7c4ca75efa3e642f4a2c0cdcd72be3cafa3c305a 100644
--- a/ipatests/test_webui/ui_driver.py
+++ b/ipatests/test_webui/ui_driver.py
@@ -1289,7 +1289,6 @@ class UI_driver(object):
 )
 
 # Find
-
 self.find_record(parent_entity, data, search_facet)
 
 # 3. Navigate to