Re: [Freeipa-devel] [PATCH 0001] Test Topology plugin is listed among DS plugins

2015-07-27 Thread Martin Basti
On 23/07/15 16:27, Martin Basti wrote: On 23/07/15 11:42, Oleg Fayans wrote: Forgot to attach the new version, sorry! On 07/23/2015 10:32 AM, Oleg Fayans wrote: Hi Martin, On 07/22/2015 05:48 PM, Martin Basti wrote: On 22/07/15 15:19, Oleg Fayans wrote: Hi Martin, Fixed. On 07/22/2015

Re: [Freeipa-devel] [PATCH 0001] Test Topology plugin is listed among DS plugins

2015-07-23 Thread Martin Basti
On 23/07/15 11:42, Oleg Fayans wrote: Forgot to attach the new version, sorry! On 07/23/2015 10:32 AM, Oleg Fayans wrote: Hi Martin, On 07/22/2015 05:48 PM, Martin Basti wrote: On 22/07/15 15:19, Oleg Fayans wrote: Hi Martin, Fixed. On 07/22/2015 09:26 AM, Martin Basti wrote: On 22/07/15

Re: [Freeipa-devel] [PATCH 0001] Test Topology plugin is listed among DS plugins

2015-07-23 Thread Oleg Fayans
Forgot to attach the new version, sorry! On 07/23/2015 10:32 AM, Oleg Fayans wrote: Hi Martin, On 07/22/2015 05:48 PM, Martin Basti wrote: On 22/07/15 15:19, Oleg Fayans wrote: Hi Martin, Fixed. On 07/22/2015 09:26 AM, Martin Basti wrote: On 22/07/15 09:23, Oleg Fayans wrote: Hi Martin,

Re: [Freeipa-devel] [PATCH 0001] Test Topology plugin is listed among DS plugins

2015-07-23 Thread Oleg Fayans
Hi Martin, On 07/22/2015 05:48 PM, Martin Basti wrote: On 22/07/15 15:19, Oleg Fayans wrote: Hi Martin, Fixed. On 07/22/2015 09:26 AM, Martin Basti wrote: On 22/07/15 09:23, Oleg Fayans wrote: Hi Martin, Patch updated. Thank you for the review! On 07/21/2015 05:45 PM, Martin Basti wrote:

Re: [Freeipa-devel] [PATCH 0001] Test Topology plugin is listed among DS plugins

2015-07-22 Thread Martin Basti
On 22/07/15 15:19, Oleg Fayans wrote: Hi Martin, Fixed. On 07/22/2015 09:26 AM, Martin Basti wrote: On 22/07/15 09:23, Oleg Fayans wrote: Hi Martin, Patch updated. Thank you for the review! On 07/21/2015 05:45 PM, Martin Basti wrote: On 20/07/15 14:07, Oleg Fayans wrote: Hi Martin,

Re: [Freeipa-devel] [PATCH 0001] Test Topology plugin is listed among DS plugins

2015-07-22 Thread Martin Basti
On 22/07/15 09:23, Oleg Fayans wrote: Hi Martin, Patch updated. Thank you for the review! On 07/21/2015 05:45 PM, Martin Basti wrote: On 20/07/15 14:07, Oleg Fayans wrote: Hi Martin, Updated. On 07/20/2015 12:46 PM, Martin Basti wrote: On 20/07/15 11:57, Oleg Fayans wrote: +

Re: [Freeipa-devel] [PATCH 0001] Test Topology plugin is listed among DS plugins

2015-07-22 Thread Oleg Fayans
Hi Martin, Patch updated. Thank you for the review! On 07/21/2015 05:45 PM, Martin Basti wrote: On 20/07/15 14:07, Oleg Fayans wrote: Hi Martin, Updated. On 07/20/2015 12:46 PM, Martin Basti wrote: On 20/07/15 11:57, Oleg Fayans wrote: +pwfile = api.env.dot_ipa + os.sep + .dmpw +

Re: [Freeipa-devel] [PATCH 0001] Test Topology plugin is listed among DS plugins

2015-07-21 Thread Martin Basti
On 20/07/15 14:07, Oleg Fayans wrote: Hi Martin, Updated. On 07/20/2015 12:46 PM, Martin Basti wrote: On 20/07/15 11:57, Oleg Fayans wrote: +pwfile = api.env.dot_ipa + os.sep + .dmpw +if ipautil.file_exists(pwfile): +fp = open(pwfile, r) +dm_password

[Freeipa-devel] [PATCH 0001] Test Topology plugin is listed among DS plugins

2015-07-20 Thread Oleg Fayans
A simple test to check that Topology Plugin has registered itself in the ldap tree. -- Oleg Fayans Quality Engineer FreeIPA team RedHat. From 49280b12b1701c3baf095c8d3c209e14dce0dcde Mon Sep 17 00:00:00 2001 From: Oleg Fayans ofay...@redhat.com Date: Mon, 20 Jul 2015 11:50:32 +0200 Subject:

Re: [Freeipa-devel] [PATCH 0001] Test Topology plugin is listed among DS plugins

2015-07-20 Thread Martin Basti
On 20/07/15 11:57, Oleg Fayans wrote: +pwfile = api.env.dot_ipa + os.sep + .dmpw +if ipautil.file_exists(pwfile): +fp = open(pwfile, r) +dm_password = fp.read().rstrip() +fp.close() +else: Hello, 1) Can you use os.path.join() instead

Re: [Freeipa-devel] [PATCH 0001] Test Topology plugin is listed among DS plugins

2015-07-20 Thread Oleg Fayans
Hi Martin, Updated. On 07/20/2015 12:46 PM, Martin Basti wrote: On 20/07/15 11:57, Oleg Fayans wrote: +pwfile = api.env.dot_ipa + os.sep + .dmpw +if ipautil.file_exists(pwfile): +fp = open(pwfile, r) +dm_password = fp.read().rstrip() +