Re: [Freeipa-devel] [PATCH 0012-0012] more topology plugin fixes

2015-06-11 Thread Oleg Fayans
Hi Ludwig Installed it and it did fix the problem with orphaned topology segments after replica removal. Thank you very much! One more question: In which cases the segment removal should be allowed via `ipa topologysegment-del` command? Currently, when I try to remove a segment, that connects

Re: [Freeipa-devel] [PATCH 0012-0012] more topology plugin fixes

2015-06-11 Thread Petr Vobornik
On 06/11/2015 11:27 AM, Ludwig Krispenz wrote: Thanks, attached a new version with comments and trying to use more meaningful function names snip Ok. Thanks for the explanations. To help reading you may add a comment saying the the first test is related to RA and the second to segments.

Re: [Freeipa-devel] [PATCH 0012-0012] more topology plugin fixes

2015-06-11 Thread Ludwig Krispenz
Thanks, attached a new version with comments and trying to use more meaningful function names On 06/11/2015 10:49 AM, thierry bordaz wrote: On 06/11/2015 10:40 AM, Ludwig Krispenz wrote: On 06/11/2015 10:27 AM, thierry bordaz wrote: On 06/11/2015 08:12 AM, Ludwig Krispenz wrote: Attached

Re: [Freeipa-devel] [PATCH 0012-0012] more topology plugin fixes

2015-06-11 Thread thierry bordaz
On 06/11/2015 10:40 AM, Ludwig Krispenz wrote: On 06/11/2015 10:27 AM, thierry bordaz wrote: On 06/11/2015 08:12 AM, Ludwig Krispenz wrote: Attached are two patches: - reject direct modification of segment endpoints and connectivity - better manage the rdn of a replication agreements

Re: [Freeipa-devel] [PATCH 0012-0012] more topology plugin fixes

2015-06-11 Thread Ludwig Krispenz
On 06/11/2015 11:06 AM, Oleg Fayans wrote: Hi Ludwig Installed it and it did fix the problem with orphaned topology segments after replica removal. Thank you very much! One more question: In which cases the segment removal should be allowed via `ipa topologysegment-del` command? Currently,

[Freeipa-devel] [PATCH 0012-0012] more topology plugin fixes

2015-06-11 Thread Ludwig Krispenz
Attached are two patches: - reject direct modification of segment endpoints and connectivity - better manage the rdn of a replication agreements represented by a segment From b7d72c390cd4ea021d9c818156c07de4fc2b0921 Mon Sep 17 00:00:00 2001 From: Ludwig Krispenz lkris...@redhat.com Date: Wed, 10

Re: [Freeipa-devel] [PATCH 0012-0012] more topology plugin fixes

2015-06-11 Thread thierry bordaz
On 06/11/2015 08:12 AM, Ludwig Krispenz wrote: Attached are two patches: - reject direct modification of segment endpoints and connectivity - better manage the rdn of a replication agreements represented by a segment Hello Ludwig, The patches looks good. Two questions: * Patch 0012