Re: [Freeipa-devel] [PATCH 0013-0021] Coverity patches

2016-02-01 Thread Jan Cholasta
Hi, On 29.1.2016 15:49, Martin Basti wrote: On 29.01.2016 15:49, Stanislav Laznicka wrote: Reworded the commits so that they better reflect what's going on in those. On 01/29/2016 02:49 PM, Stanislav Laznicka wrote: Hello, I made some patches based on the Coverity report from 18.1.2016.

Re: [Freeipa-devel] [PATCH 0013-0021] Coverity patches

2016-02-01 Thread Jan Cholasta
On 1.2.2016 12:11, Petr Spacek wrote: On 1.2.2016 09:03, Jan Cholasta wrote: Hi, On 29.1.2016 15:49, Martin Basti wrote: On 29.01.2016 15:49, Stanislav Laznicka wrote: Reworded the commits so that they better reflect what's going on in those. On 01/29/2016 02:49 PM, Stanislav Laznicka

Re: [Freeipa-devel] [PATCH 0013-0021] Coverity patches

2016-02-01 Thread Petr Spacek
On 1.2.2016 09:03, Jan Cholasta wrote: > Hi, > > On 29.1.2016 15:49, Martin Basti wrote: >> >> >> On 29.01.2016 15:49, Stanislav Laznicka wrote: >>> Reworded the commits so that they better reflect what's going on in those. >>> >>> On 01/29/2016 02:49 PM, Stanislav Laznicka wrote: Hello,

Re: [Freeipa-devel] [PATCH 0013-0021] Coverity patches

2016-01-29 Thread Martin Basti
On 29.01.2016 15:49, Stanislav Laznicka wrote: Reworded the commits so that they better reflect what's going on in those. On 01/29/2016 02:49 PM, Stanislav Laznicka wrote: Hello, I made some patches based on the Coverity report from 18.1.2016. Cheers, Standa NACK, see my previous

Re: [Freeipa-devel] [PATCH 0013-0021] Coverity patches

2016-01-29 Thread Stanislav Laznicka
Reworded the commits so that they better reflect what's going on in those. On 01/29/2016 02:49 PM, Stanislav Laznicka wrote: Hello, I made some patches based on the Coverity report from 18.1.2016. Cheers, Standa From 56bfba733321388190cf6df0ec0dfab5fff15996 Mon Sep 17 00:00:00 2001 From:

Re: [Freeipa-devel] [PATCH 0013-0021] Coverity patches

2016-01-29 Thread Martin Basti
On 29.01.2016 14:49, Stanislav Laznicka wrote: Hello, I made some patches based on the Coverity report from 18.1.2016. Cheers, Standa NACK *) please describe issue in commit message instead of #coverity number in all patches PATCH: Removing dead code LGTM PATCH: Wrong assert I'm not

[Freeipa-devel] [PATCH 0013-0021] Coverity patches

2016-01-29 Thread Stanislav Laznicka
Hello, I made some patches based on the Coverity report from 18.1.2016. Cheers, Standa From 89a945cb78b324757636dbcaddabc2616d57bde2 Mon Sep 17 00:00:00 2001 From: Stanislav Laznicka Date: Fri, 29 Jan 2016 08:57:06 +0100 Subject: [PATCH 1/9] Removing dead code Coverity