[Freeipa-devel] [PATCH 0016] Clarify error message about missing DNS component in ipa-replica-prepare

2014-02-21 Thread Petr Spacek

Hello,

Clarify error message about missing DNS component in ipa-replica-prepare.

Use 'dane' on #freeipa channel have spent half an hour finding out what is 
wrong because the error message was misleading. I think that it is enough to 
justify this change :-)


--
Petr^2 Spacek
From 8161ff3f69313a0780e3134da45b3dc1fb9334cb Mon Sep 17 00:00:00 2001
From: Petr Spacek pspa...@redhat.com
Date: Fri, 21 Feb 2014 14:48:05 +0100
Subject: [PATCH] Clarify error message about missing DNS component in
 ipa-replica-prepare.

---
 ipaserver/install/ipa_replica_prepare.py | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/ipaserver/install/ipa_replica_prepare.py b/ipaserver/install/ipa_replica_prepare.py
index bd5244d4f8a7e02ceaea1a287dce9fc5109beec9..c786569e292528196aff6c16c4fcd7796e66eda4 100644
--- a/ipaserver/install/ipa_replica_prepare.py
+++ b/ipaserver/install/ipa_replica_prepare.py
@@ -202,8 +202,11 @@ class ReplicaPrepare(admintool.AdminTool):
 if not dns_container_exists(api.env.host, api.env.basedn,
 dm_password=self.dirman_password,
 ldapi=True, realm=api.env.realm):
-raise admintool.ScriptError(You can't add a DNS record 
-because DNS is not set up.)
+self.log.error(
+It is not possible to add a DNS record automatically 
+because DNS is not managed by IPA. Please create DNS 
+record manually and then omit --ip-address option.)
+raise admintool.ScriptError(Cannot add DNS record)
 if options.reverse_zone and not bindinstance.verify_reverse_zone(
 options.reverse_zone, options.ip_address):
 raise admintool.ScriptError(Invalid reverse zone)
-- 
1.8.5.3

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0016] Clarify error message about missing DNS component in ipa-replica-prepare

2014-02-21 Thread Petr Viktorin

On 02/21/2014 02:57 PM, Petr Spacek wrote:

Hello,

Clarify error message about missing DNS component in ipa-replica-prepare.

Use 'dane' on #freeipa channel have spent half an hour finding out what
is wrong because the error message was misleading. I think that it is
enough to justify this change :-)


Sounds reasonable. I'll take the patch review.
https://fedorahosted.org/freeipa/ticket/4188

--
PetrĀ³

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH 0016] Clarify error message about missing DNS component in ipa-replica-prepare

2014-02-21 Thread Petr Viktorin

On 02/21/2014 03:25 PM, Petr Viktorin wrote:

On 02/21/2014 02:57 PM, Petr Spacek wrote:

Hello,

Clarify error message about missing DNS component in ipa-replica-prepare.

Use 'dane' on #freeipa channel have spent half an hour finding out what
is wrong because the error message was misleading. I think that it is
enough to justify this change :-)


Sounds reasonable. I'll take the patch review.
https://fedorahosted.org/freeipa/ticket/4188



ACK, pushed to master: dd55e13aa94a7540324239cac61b286262542d1e

--
PetrĀ³

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel