Re: [Freeipa-devel] [PATCH 0022] topology plugin prevents deletes but does not prevent moddn

2016-01-21 Thread Martin Basti
On 21.01.2016 11:35, thierry bordaz wrote: On 01/21/2016 11:26 AM, Ludwig Krispenz wrote: On 01/21/2016 11:21 AM, thierry bordaz wrote: On 01/21/2016 10:48 AM, Ludwig Krispenz wrote: On 01/21/2016 10:30 AM, thierry bordaz wrote: Hi, The fix look good. Just a question, the target entry

Re: [Freeipa-devel] [PATCH 0022] topology plugin prevents deletes but does not prevent moddn

2016-01-21 Thread thierry bordaz
Hi, The fix look good. Just a question, the target entry is checked with ipa_topo_check_entry_type. Is it equivalent to call ipa_topo_is_entry_managed ? thanks thierry On 01/21/2016 09:11 AM, Ludwig Krispenz wrote: On 01/20/2016 05:45 PM, Martin Basti wrote: On 11.12.2015 13:56, Ludwig

Re: [Freeipa-devel] [PATCH 0022] topology plugin prevents deletes but does not prevent moddn

2016-01-21 Thread Ludwig Krispenz
On 01/21/2016 11:21 AM, thierry bordaz wrote: On 01/21/2016 10:48 AM, Ludwig Krispenz wrote: On 01/21/2016 10:30 AM, thierry bordaz wrote: Hi, The fix look good. Just a question, the target entry is checked with ipa_topo_check_entry_type. Is it equivalent to call ipa_topo_is_entry_managed

Re: [Freeipa-devel] [PATCH 0022] topology plugin prevents deletes but does not prevent moddn

2016-01-21 Thread Ludwig Krispenz
On 01/20/2016 05:45 PM, Martin Basti wrote: On 11.12.2015 13:56, Ludwig Krispenz wrote: Ticket: https://fedorahosted.org/freeipa/ticket/5536 Patch attached. Patch works, I cannot move entry out of container via moddn operation. I have question, is it expected to be able rename entry? I

Re: [Freeipa-devel] [PATCH 0022] topology plugin prevents deletes but does not prevent moddn

2016-01-21 Thread thierry bordaz
On 01/21/2016 11:26 AM, Ludwig Krispenz wrote: On 01/21/2016 11:21 AM, thierry bordaz wrote: On 01/21/2016 10:48 AM, Ludwig Krispenz wrote: On 01/21/2016 10:30 AM, thierry bordaz wrote: Hi, The fix look good. Just a question, the target entry is checked with ipa_topo_check_entry_type. Is

Re: [Freeipa-devel] [PATCH 0022] topology plugin prevents deletes but does not prevent moddn

2016-01-21 Thread Ludwig Krispenz
On 01/21/2016 10:30 AM, thierry bordaz wrote: Hi, The fix look good. Just a question, the target entry is checked with ipa_topo_check_entry_type. Is it equivalent to call ipa_topo_is_entry_managed ? no, ipa_topo_check_entry_type() just determines if it is a segment, a host, to decide how to

Re: [Freeipa-devel] [PATCH 0022] topology plugin prevents deletes but does not prevent moddn

2016-01-21 Thread thierry bordaz
On 01/21/2016 10:48 AM, Ludwig Krispenz wrote: On 01/21/2016 10:30 AM, thierry bordaz wrote: Hi, The fix look good. Just a question, the target entry is checked with ipa_topo_check_entry_type. Is it equivalent to call ipa_topo_is_entry_managed ? no, ipa_topo_check_entry_type() just

Re: [Freeipa-devel] [PATCH 0022] topology plugin prevents deletes but does not prevent moddn

2016-01-20 Thread Martin Basti
On 11.12.2015 13:56, Ludwig Krispenz wrote: Ticket: https://fedorahosted.org/freeipa/ticket/5536 Patch attached. Patch works, I cannot move entry out of container via moddn operation. I have question, is it expected to be able rename entry? I tried it and I was able to change RDN

[Freeipa-devel] [PATCH 0022] topology plugin prevents deletes but does not prevent moddn

2015-12-11 Thread Ludwig Krispenz
Ticket: https://fedorahosted.org/freeipa/ticket/5536 Patch attached. >From 592c2cfece7c1f0860cacc72b642826d5b4a7791 Mon Sep 17 00:00:00 2001 From: Ludwig Krispenz Date: Fri, 11 Dec 2015 13:50:53 +0100 Subject: [PATCH] prevent moving of topology entries out of managed scope