Re: [Freeipa-devel] [PATCH 0039] Deprecate --domain-level option from ipa-server-install

2016-06-02 Thread Martin Basti



On 02.06.2016 14:15, Stanislav Laznicka wrote:
I had a different solution prepared but it seems that the deprecated 
flag in KnobBase does the trick. Although if the only thing it does is 
to remove the option from help, it may need to be renamed 
(help_hidden, maybe?).


https://fedorahosted.org/freeipa/ticket/5907




ACK

Pushed to:
master: 3076cb9dcc8afc3f7d2525226772f2494b6d2cd5
ipa-4-3: de23e96795b3a707d313092c8a1b9d6b296ce819

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH 0039] Deprecate --domain-level option from ipa-server-install

2016-06-02 Thread Stanislav Laznicka
I had a different solution prepared but it seems that the deprecated 
flag in KnobBase does the trick. Although if the only thing it does is 
to remove the option from help, it may need to be renamed (help_hidden, 
maybe?).


https://fedorahosted.org/freeipa/ticket/5907

From 0ee60e059d33d3f55fab2e41e2198853d9116f32 Mon Sep 17 00:00:00 2001
From: Stanislav Laznicka 
Date: Thu, 2 Jun 2016 14:08:32 +0200
Subject: [PATCH] Deprecated the domain-level option in ipa-server-install

https://fedorahosted.org/freeipa/ticket/5907
---
 ipaserver/install/server/install.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ipaserver/install/server/install.py b/ipaserver/install/server/install.py
index 2d71b3837214683566f37644c41a680953a64207..113c2b27733eebe8aa22029c2961ee6eb3e248b2 100644
--- a/ipaserver/install/server/install.py
+++ b/ipaserver/install/server/install.py
@@ -1367,6 +1367,7 @@ class Server(BaseServer):
 int, constants.MAX_DOMAIN_LEVEL,
 description="IPA domain level",
 cli_name='domain-level',
+deprecated=True,
 )
 
 @domainlevel.validator
-- 
2.5.5

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code