Re: [Freeipa-devel] [PATCH 0095] Fix RADIUS capitalization

2016-05-28 Thread Martin Basti



On 27.05.2016 18:17, Nathaniel McCallum wrote:

RADIUS is an acryonym. This patch fixes its usage to match our
capitalization of other acronyms, like OTP.


Hi Nathaniel, I don't think that translations should be modified by this 
patch, because translation will be replaced by pulling new translations 
from zanata, this should be changed on zanata side


Martin^2
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH 0095] Fix RADIUS capitalization

2016-05-27 Thread Nathaniel McCallum
RADIUS is an acryonym. This patch fixes its usage to match our
capitalization of other acronyms, like OTP.From 33f10766a9793531984d3be3fb7ec12c8ab1cde0 Mon Sep 17 00:00:00 2001
From: Nathaniel McCallum 
Date: Fri, 27 May 2016 12:10:00 -0400
Subject: [PATCH] Fix RADIUS capitalization

RADIUS is an acryonym. This patch fixes its usage to match our
capitalization of other acronyms, like OTP.
---
 daemons/ipa-otpd/main.c   | 4 ++--
 install/po/de.po  | 4 ++--
 install/po/fr.po  | 4 ++--
 install/po/ipa.pot| 2 +-
 install/po/uk.po  | 4 ++--
 install/ui/src/freeipa/radiusproxy.js | 4 ++--
 install/ui/test/data/ipa_init.json| 2 +-
 ipalib/plugins/internal.py| 2 +-
 8 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/daemons/ipa-otpd/main.c b/daemons/ipa-otpd/main.c
index aebc039bc05e5ddd04de2c0647a1cdb851a1b697..25906d0e36c7211ecaadcb4c8c9ed9b73ed7aa2b 100644
--- a/daemons/ipa-otpd/main.c
+++ b/daemons/ipa-otpd/main.c
@@ -270,10 +270,10 @@ int main(int argc, char **argv)
 goto error;
 }
 
-/* Radius Client */
+/* RADIUS Client */
 retval = krad_client_new(ctx.kctx, ctx.vctx, &ctx.client);
 if (retval != 0) {
-otpd_log_err(retval, "Unable to initialize radius client");
+otpd_log_err(retval, "Unable to initialize RADIUS client");
 goto error;
 }
 
diff --git a/install/po/de.po b/install/po/de.po
index 35d20932060ea8865aa8cb7b19a57e4e0e3d8469..d98cc9676e6a49c6b9f860cc706bb02cb42143e3 100644
--- a/install/po/de.po
+++ b/install/po/de.po
@@ -2359,8 +2359,8 @@ msgstr ""
 msgid "Two factor authentication (password + OTP)"
 msgstr "Zwei-Faktor-Authentifizierung (Passwort + Einmalpasswort)"
 
-msgid "Radius"
-msgstr "Radius"
+msgid "RADIUS"
+msgstr "RADIUS"
 
 msgid "About"
 msgstr "Über"
diff --git a/install/po/fr.po b/install/po/fr.po
index cefe28797ba0d89e7361980e3f851577738d8b63..6153641e903a3221bd8eae7b0bafe9244478f5c1 100644
--- a/install/po/fr.po
+++ b/install/po/fr.po
@@ -7643,8 +7643,8 @@ msgstr ""
 msgid "Two factor authentication (password + OTP)"
 msgstr "Authentification à deux-facteurs"
 
-msgid "Radius"
-msgstr "Radius"
+msgid "RADIUS"
+msgstr "RADIUS"
 
 msgid "Disable per-user override"
 msgstr "Désactiver la surcharge par utilisateur"
diff --git a/install/po/ipa.pot b/install/po/ipa.pot
index 8256bb77da282d6c327a761ffd07c31b8fc7bf28..ea1fe9412b261c4f2520d05f4d888e9645957d97 100644
--- a/install/po/ipa.pot
+++ b/install/po/ipa.pot
@@ -7527,7 +7527,7 @@ msgid "Two factor authentication (password + OTP)"
 msgstr ""
 
 #: ipalib/plugins/internal.py:198
-msgid "Radius"
+msgid "RADIUS"
 msgstr ""
 
 #: ipalib/plugins/internal.py:199
diff --git a/install/po/uk.po b/install/po/uk.po
index cb7f8705ccc0e51469c111eb7485eaa6ed580195..04e9034ae8b5971ab4b91fa75fd8058321b3357d 100644
--- a/install/po/uk.po
+++ b/install/po/uk.po
@@ -7648,8 +7648,8 @@ msgstr ""
 msgid "Two factor authentication (password + OTP)"
 msgstr "Двофакторне розпізнавання (пароль + OTP)"
 
-msgid "Radius"
-msgstr "Radius"
+msgid "RADIUS"
+msgstr "RADIUS"
 
 msgid "Disable per-user override"
 msgstr "Вимкнути перевизначення на рівні користувача"
diff --git a/install/ui/src/freeipa/radiusproxy.js b/install/ui/src/freeipa/radiusproxy.js
index 056d9504c198f6d54ad3d75aa490cb458dab15b6..3b523e5313434b3da2e198f139b1f1e96ca902a8 100644
--- a/install/ui/src/freeipa/radiusproxy.js
+++ b/install/ui/src/freeipa/radiusproxy.js
@@ -32,7 +32,7 @@ define([
 function(IPA, $, menu, phases, reg) {
 
 /**
- * Radius module
+ * RADIUS module
  * @class
  * @singleton
  */
@@ -115,7 +115,7 @@ return {
 };};
 
 /**
- * Radius specification object
+ * RADIUS specification object
  */
 radiusproxy.spec = make_spec();
 
diff --git a/install/ui/test/data/ipa_init.json b/install/ui/test/data/ipa_init.json
index 1b9b69ff909a9668c1e1867008459d25d5e062a9..d2f18a3d7ff60cf55df27f9d0f42874e9de1d008 100644
--- a/install/ui/test/data/ipa_init.json
+++ b/install/ui/test/data/ipa_init.json
@@ -52,7 +52,7 @@
 "config_tooltip": "Implicit method (password) will be used if no method is chosen.Password + Two-factor: LDAP and Kerberos allow authentication with either one of the authentication types but Kerberos uses pre-authentication method which requires to use armor ccache.RADIUS with another type: Kerberos always use RADIUS, but LDAP never does. LDAP only recognize the password and two-factor authentication options.",
 "type_otp": "Two factor authentication (password + OTP)",
 "type_password": "Password",
-"type_radius": "Radius",
+"type_radius": "RADIUS",
 "type_disabled": "Disable per-user override",
 "user_tooltip": "Per-user setting, overwrites the global setting if any option is checked.Password + Two-factor: LDAP and Kerberos al