Re: [Freeipa-devel] [PATCH 0095] remove an unneccesary check from IPA server uninstaller

2015-11-12 Thread Jan Cholasta 

On 11.11.2015 16:32, Jan Cholasta wrote:

On 11.11.2015 16:24, Martin Babinsky wrote:

This check for a deprecated option added in
  https://fedorahosted.org/freeipa/ticket/4516 and somehow ended up in
both install_check and uninstall_check during installer refactoring.

The placement in the latter is rather pointless so this patch removes it.


ACK.


Pushed to master: d66492c15e847ffe68829e1b92cc43dbc60c4c7d

--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0095] remove an unneccesary check from IPA server uninstaller

2015-11-11 Thread Jan Cholasta 

On 11.11.2015 16:24, Martin Babinsky wrote:

This check for a deprecated option added in
  https://fedorahosted.org/freeipa/ticket/4516 and somehow ended up in
both install_check and uninstall_check during installer refactoring.

The placement in the latter is rather pointless so this patch removes it.


ACK.

--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH 0095] remove an unneccesary check from IPA server uninstaller

2015-11-11 Thread Martin Babinsky 

This check for a deprecated option added in
 https://fedorahosted.org/freeipa/ticket/4516 and somehow ended up in 
both install_check and uninstall_check during installer refactoring.


The placement in the latter is rather pointless so this patch removes it.

--
Martin^3 Babinsky
From 9835b6cd043db968040f6ddd1bfa41a76ca29ad0 Mon Sep 17 00:00:00 2001
From: Martin Babinsky 
Date: Wed, 11 Nov 2015 15:34:32 +0100
Subject: [PATCH] remove an unneccesary check from IPA server uninstaller

---
 ipaserver/install/server/install.py | 7 ---
 1 file changed, 7 deletions(-)

diff --git a/ipaserver/install/server/install.py b/ipaserver/install/server/install.py
index 16539892dcffb3ad0e95aab0c5a3d85f3bb44c48..6629e8ec12f50c83a691dcd60e2cbf1125598fcb 100644
--- a/ipaserver/install/server/install.py
+++ b/ipaserver/install/server/install.py
@@ -959,13 +959,6 @@ def uninstall_check(installer):
 
 tasks.check_selinux_status()
 
-if options.master_password:
-msg = ("WARNING:\noption '-P/--master-password' is deprecated. "
-   "KDC master password of sufficient strength is autogenerated "
-   "during IPA server installation and should not be set "
-   "manually.")
-print(textwrap.fill(msg, width=79, replace_whitespace=False))
-
 installer._installation_cleanup = False
 
 if not is_ipa_configured():
-- 
2.4.3

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code