Re: [Freeipa-devel] [PATCH 0116] Refactoring of service autobind

2014-09-26 Thread Martin Kosek
On 09/25/2014 03:06 PM, Martin Basti wrote: On 25/09/14 14:47, Jan Cholasta wrote: Dne 25.9.2014 v 10:51 Martin Basti napsal(a): On 19/09/14 14:30, Jan Cholasta wrote: Dne 19.9.2014 v 13:32 Martin Basti napsal(a): On 01/09/14 16:26, Martin Basti wrote: On 28/08/14 14:01, Jan Cholasta wrote:

Re: [Freeipa-devel] [PATCH 0116] Refactoring of service autobind

2014-09-25 Thread Martin Basti
On 19/09/14 14:30, Jan Cholasta wrote: Dne 19.9.2014 v 13:32 Martin Basti napsal(a): On 01/09/14 16:26, Martin Basti wrote: On 28/08/14 14:01, Jan Cholasta wrote: Hi, Dne 27.8.2014 v 15:22 Martin Basti napsal(a): Patch attached. 1) Please rename object_exists to entry_exists. 2) Use

Re: [Freeipa-devel] [PATCH 0116] Refactoring of service autobind

2014-09-25 Thread Jan Cholasta
Dne 25.9.2014 v 10:51 Martin Basti napsal(a): On 19/09/14 14:30, Jan Cholasta wrote: Dne 19.9.2014 v 13:32 Martin Basti napsal(a): On 01/09/14 16:26, Martin Basti wrote: On 28/08/14 14:01, Jan Cholasta wrote: Hi, Dne 27.8.2014 v 15:22 Martin Basti napsal(a): Patch attached. 1) Please

Re: [Freeipa-devel] [PATCH 0116] Refactoring of service autobind

2014-09-25 Thread Martin Basti
On 25/09/14 14:47, Jan Cholasta wrote: Dne 25.9.2014 v 10:51 Martin Basti napsal(a): On 19/09/14 14:30, Jan Cholasta wrote: Dne 19.9.2014 v 13:32 Martin Basti napsal(a): On 01/09/14 16:26, Martin Basti wrote: On 28/08/14 14:01, Jan Cholasta wrote: Hi, Dne 27.8.2014 v 15:22 Martin Basti

Re: [Freeipa-devel] [PATCH 0116] Refactoring of service autobind

2014-09-19 Thread Martin Basti
On 01/09/14 16:26, Martin Basti wrote: On 28/08/14 14:01, Jan Cholasta wrote: Hi, Dne 27.8.2014 v 15:22 Martin Basti napsal(a): Patch attached. 1) Please rename object_exists to entry_exists. 2) Use empty attribute list in get_entry() in object_exists/entry_exists. 3) Please update

Re: [Freeipa-devel] [PATCH 0116] Refactoring of service autobind

2014-09-19 Thread Jan Cholasta
Dne 19.9.2014 v 13:32 Martin Basti napsal(a): On 01/09/14 16:26, Martin Basti wrote: On 28/08/14 14:01, Jan Cholasta wrote: Hi, Dne 27.8.2014 v 15:22 Martin Basti napsal(a): Patch attached. 1) Please rename object_exists to entry_exists. 2) Use empty attribute list in get_entry() in

Re: [Freeipa-devel] [PATCH 0116] Refactoring of service autobind

2014-09-19 Thread Martin Basti
On 19/09/14 14:30, Jan Cholasta wrote: Dne 19.9.2014 v 13:32 Martin Basti napsal(a): On 01/09/14 16:26, Martin Basti wrote: On 28/08/14 14:01, Jan Cholasta wrote: Hi, Dne 27.8.2014 v 15:22 Martin Basti napsal(a): Patch attached. 1) Please rename object_exists to entry_exists. 2) Use

Re: [Freeipa-devel] [PATCH 0116] Refactoring of service autobind

2014-09-19 Thread Jan Cholasta
Dne 19.9.2014 v 14:39 Martin Basti napsal(a): On 19/09/14 14:30, Jan Cholasta wrote: Dne 19.9.2014 v 13:32 Martin Basti napsal(a): On 01/09/14 16:26, Martin Basti wrote: On 28/08/14 14:01, Jan Cholasta wrote: Hi, Dne 27.8.2014 v 15:22 Martin Basti napsal(a): Patch attached. 1) Please

Re: [Freeipa-devel] [PATCH 0116] Refactoring of service autobind

2014-09-01 Thread Martin Basti
On 28/08/14 14:01, Jan Cholasta wrote: Hi, Dne 27.8.2014 v 15:22 Martin Basti napsal(a): Patch attached. 1) Please rename object_exists to entry_exists. 2) Use empty attribute list in get_entry() in object_exists/entry_exists. 3) Please update LDAPObject.get_dn_if_exists() to use

Re: [Freeipa-devel] [PATCH 0116] Refactoring of service autobind

2014-08-28 Thread Jan Cholasta
Hi, Dne 27.8.2014 v 15:22 Martin Basti napsal(a): Patch attached. 1) Please rename object_exists to entry_exists. 2) Use empty attribute list in get_entry() in object_exists/entry_exists. 3) Please update LDAPObject.get_dn_if_exists() to use object_exists/entry_exists. 4) I'm not a

[Freeipa-devel] [PATCH 0116] Refactoring of service autobind

2014-08-27 Thread Martin Basti
Patch attached. -- Martin Basti From edab57193c37e62f809a842c274550ff1d2ee5d6 Mon Sep 17 00:00:00 2001 From: Martin Basti mba...@redhat.com Date: Wed, 27 Aug 2014 15:06:42 +0200 Subject: [PATCH] Refactoring of autobind, object_exists Required to prevent code duplications ipaldap.IPAdmin now