On 12/11/2014 05:44 PM, Petr Spacek wrote:
On 11.12.2014 16:50, Martin Basti wrote:
Updated aptch attached:
Nice work, ACK!
Can we also add some tests? This is a lot of new code that could break stuff.
___
Freeipa-devel mailing list
On 12/12/14 13:50, Martin Kosek wrote:
On 12/11/2014 05:44 PM, Petr Spacek wrote:
On 11.12.2014 16:50, Martin Basti wrote:
Updated aptch attached:
Nice work, ACK!
Can we also add some tests? This is a lot of new code that could break
stuff.
We can, in week maybe or after christmas,
Hello,
I have only few nitpicks and one minor non-nitpick. Rest is in-line.
On 10.12.2014 18:20, Martin Basti wrote:
freeipa-mbasti-0170.4-Detect-and-warn-about-invalid-DNS-forward-zone-confi.patch
From a1b70e7a12ffdb08941d43587a05d7e36b57ab2b Mon Sep 17 00:00:00 2001
From: Martin Basti
Updated aptch attached:
diff with previous:
diff --git a/ipalib/plugins/dns.py b/ipalib/plugins/dns.py
index f9d8321..7a80036 100644
--- a/ipalib/plugins/dns.py
+++ b/ipalib/plugins/dns.py
@@ -1735,7 +1735,7 @@ def _normalize_zone(zone):
def _get_auth_zone_ldap(name):
-Find
On 11.12.2014 16:50, Martin Basti wrote:
Updated aptch attached:
Nice work, ACK!
--
Petr^2 Spacek
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
On 09/12/14 17:40, Martin Basti wrote:
On 01/12/14 17:44, Petr Spacek wrote:
On 1.12.2014 14:39, Martin Basti wrote:
On 24/11/14 17:24, Petr Spacek wrote:
Hello!
Thank you for the patch. It is not ready yet but the overall
direction seems
good. Please see my comments in-line.
On
On 01/12/14 17:44, Petr Spacek wrote:
On 1.12.2014 14:39, Martin Basti wrote:
On 24/11/14 17:24, Petr Spacek wrote:
Hello!
Thank you for the patch. It is not ready yet but the overall direction seems
good. Please see my comments in-line.
On 24.11.2014 14:35, Martin Basti wrote:
Ticket:
On 24/11/14 17:24, Petr Spacek wrote:
Hello!
Thank you for the patch. It is not ready yet but the overall direction seems
good. Please see my comments in-line.
On 24.11.2014 14:35, Martin Basti wrote:
Ticket: https://fedorahosted.org/freeipa/ticket/4721
Patch attached
--
Martin Basti
On 1.12.2014 14:39, Martin Basti wrote:
On 24/11/14 17:24, Petr Spacek wrote:
Hello!
Thank you for the patch. It is not ready yet but the overall direction seems
good. Please see my comments in-line.
On 24.11.2014 14:35, Martin Basti wrote:
Ticket:
Ticket: https://fedorahosted.org/freeipa/ticket/4721
Patch attached
--
Martin Basti
From a5a19137e3ddf2d2d48cfbdb2968b6f68ac8f772 Mon Sep 17 00:00:00 2001
From: Martin Basti mba...@redhat.com
Date: Fri, 21 Nov 2014 16:54:09 +0100
Subject: [PATCH] Detect and warn about invalid DNS forward zone
Hello!
Thank you for the patch. It is not ready yet but the overall direction seems
good. Please see my comments in-line.
On 24.11.2014 14:35, Martin Basti wrote:
Ticket: https://fedorahosted.org/freeipa/ticket/4721
Patch attached
--
Martin Basti
11 matches
Mail list logo