Re: [Freeipa-devel] [PATCH 0248] DNSSEC: Fix: Do not recreate kasp.db if already exists

2015-05-19 Thread Jan Cholasta

Dne 15.5.2015 v 12:10 Petr Spacek napsal(a):

On 14.5.2015 17:09, Martin Basti wrote:

https://fedorahosted.org/freeipa/ticket/4657

Patch attached.


ACK for this change but it generally it would be nice if function
__setup_dnssec had some meaningful name, e.g. __setup_opendnssec_db.



Pushed to:
master: ebd91461132d2aa7d5166d03ccfe7b0d49df2c8a
ipa-4-1: d7cfc1107bcd63eaa4c5282672c088dcbd1ebf9b

--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


Re: [Freeipa-devel] [PATCH 0248] DNSSEC: Fix: Do not recreate kasp.db if already exists

2015-05-15 Thread Petr Spacek
On 14.5.2015 17:09, Martin Basti wrote:
 https://fedorahosted.org/freeipa/ticket/4657
 
 Patch attached.

ACK for this change but it generally it would be nice if function
__setup_dnssec had some meaningful name, e.g. __setup_opendnssec_db.

-- 
Petr^2 Spacek

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


[Freeipa-devel] [PATCH 0248] DNSSEC: Fix: Do not recreate kasp.db if already exists

2015-05-14 Thread Martin Basti

https://fedorahosted.org/freeipa/ticket/4657

Patch attached.

--
Martin Basti

From f01d99f4691dacb11f860b3105f35ba408d759ec Mon Sep 17 00:00:00 2001
From: Martin Basti mba...@redhat.com
Date: Thu, 14 May 2015 16:34:25 +0200
Subject: [PATCH] DNSSEC: FIX Do not re-create kasp.db if already exists

Kasp should not be replaced by DNS reinstallation with new file.

https://fedorahosted.org/freeipa/ticket/4657
---
 ipaserver/install/opendnssecinstance.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ipaserver/install/opendnssecinstance.py b/ipaserver/install/opendnssecinstance.py
index c9c7bd1f6852f6154add6705243ac94859385a11..5384759858463b25e92b20b65ac633b79519d5dd 100644
--- a/ipaserver/install/opendnssecinstance.py
+++ b/ipaserver/install/opendnssecinstance.py
@@ -252,6 +252,7 @@ class OpenDNSSECInstance(service.Service):
 # run once only
 if self.get_state(KASP_DB_configured):
 root_logger.debug(Already configured, skipping step)
+return
 
 self.backup_state(KASP_DB_configured, True)
 
-- 
2.1.0

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code