Re: [Freeipa-devel] [PATCH 0308] Improve detection of BIND 9 isc__errno2result header file
On 26.11.2014 13:39, Tomas Hozza wrote: > On 11/25/2014 07:48 PM, Martin Basti wrote: >> > On 12/11/14 16:11, Petr Spacek wrote: >>> > > Hello, >>> > > >>> > > Improve detection of BIND 9 isc__errno2result header file. >>> > > >>> > > This header file is not in standard distribution so normal isc-config.sh >>> > > detection is not enough. >>> > > >>> > > With this patch, ./configure should work even without explicit CFLAGS >>> > > and it >>> > > should also detect that bind-devel or bind-lite-devel packages are >>> > > missing. >>> > > >>> > > >> > Works for me >> > > ACK. Pushed to master: 3e364c72f79e3cec69fc4c3263cd0bccbc467bf5 -- Petr^2 Spacek ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0308] Improve detection of BIND 9 isc__errno2result header file
On 11/25/2014 07:48 PM, Martin Basti wrote: > On 12/11/14 16:11, Petr Spacek wrote: > > Hello, > > > > Improve detection of BIND 9 isc__errno2result header file. > > > > This header file is not in standard distribution so normal isc-config.sh > > detection is not enough. > > > > With this patch, ./configure should work even without explicit CFLAGS and it > > should also detect that bind-devel or bind-lite-devel packages are missing. > > > > > Works for me > ACK. Works for me, too. Regards, -- Tomas Hozza Software Engineer - EMEA ENG Developer Experience PGP: 1D9F3C2D Red Hat Inc. http://cz.redhat.com ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0308] Improve detection of BIND 9 isc__errno2result header file
On 12/11/14 16:11, Petr Spacek wrote: Hello, Improve detection of BIND 9 isc__errno2result header file. This header file is not in standard distribution so normal isc-config.sh detection is not enough. With this patch, ./configure should work even without explicit CFLAGS and it should also detect that bind-devel or bind-lite-devel packages are missing. Works for me -- Martin Basti ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH 0308] Improve detection of BIND 9 isc__errno2result header file
Hello, Improve detection of BIND 9 isc__errno2result header file. This header file is not in standard distribution so normal isc-config.sh detection is not enough. With this patch, ./configure should work even without explicit CFLAGS and it should also detect that bind-devel or bind-lite-devel packages are missing. -- Petr^2 Spacek From e8feffa54b8e5835d32bfba2c20ef686b8349ec7 Mon Sep 17 00:00:00 2001 From: Petr Spacek Date: Wed, 12 Nov 2014 16:03:12 +0100 Subject: [PATCH] Improve detection of BIND 9 isc__errno2result header file. This header file is not in standard distribution so normal isc-config.sh detection is not enough. --- configure.ac | 17 + 1 file changed, 17 insertions(+) diff --git a/configure.ac b/configure.ac index c985908c760c974f7c02b6fa3d183e839bbeb9ad..d12ef7bb8c32f320e872d74405b980ced9bd28d8 100644 --- a/configure.ac +++ b/configure.ac @@ -65,6 +65,8 @@ fi CFLAGS="$BIND9_CFLAGS $CFLAGS" # Checks for libraries. +AC_CHECK_LIB([isc], [isc_dir_open], [], + AC_MSG_ERROR([Install BIND9 ISC development files])) AC_CHECK_LIB([dns], [dns_name_init], [], AC_MSG_ERROR([Install BIND9 development files])) AC_CHECK_LIB([ldap], [ldap_initialize], [], @@ -87,6 +89,21 @@ int main(void) { [AC_MSG_ERROR([Cross compiling is not supported.])] ) +dnl isc__errno2result() is typically not present in standard header files +AC_MSG_CHECKING([isc__errno2result availability in header files]) +AC_TRY_RUN([ +#include +int main(void) { + isc__errno2result(0); + return 0; +}], +[AC_MSG_RESULT([yes])], +[AC_MSG_ERROR([ + Can't find isc__errno2result() or header isc/errno2result.h: + Please install bind-lite-devel package or similar.])], +[AC_MSG_ERROR([Cross compiling is not supported.])] +) + dnl Older autoconf (2.59, for example) doesn't define docdir [[ ! -n "$docdir" ]] && docdir='${datadir}/doc/${PACKAGE_TARNAME}' AC_SUBST([docdir]) -- 2.1.0 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel