Hello,
fixes were pushed to master:
98808c79ff3ce96f7ddb80525d4b1968826276c7
be242e95cd25b117d3e90e583103911128a33dab
--
Petr^2 Spacek
From 98808c79ff3ce96f7ddb80525d4b1968826276c7 Mon Sep 17 00:00:00 2001
From: Petr Spacek <pspa...@redhat.com>
Date: Mon, 18 May 2015 14:44:53 +0200
Subject: [PATCH] Remove dead code from sync_ptr_validate().
---
src/syncptr.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/syncptr.c b/src/syncptr.c
index 687a141730a8a9833733e574d297855a13569357..7c3d800b795367a6ed20cdd33b74c5a2c77a4c2a 100644
--- a/src/syncptr.c
+++ b/src/syncptr.c
@@ -223,7 +223,6 @@ sync_ptr_validate(dns_name_t *a_name, const char *a_name_str, const char *ip_str
dns_dbnode_t *ptr_node = NULL;
dns_fixedname_t found_name;
- dns_rdatasetiter_t *rdataset_it = NULL;
dns_rdata_t rdata;
dns_fixedname_init(&found_name);
@@ -330,8 +329,6 @@ sync_ptr_validate(dns_name_t *a_name, const char *a_name_str, const char *ip_str
result = ISC_R_SUCCESS;
cleanup:
- if (rdataset_it != NULL)
- dns_rdatasetiter_destroy(&rdataset_it);
if (ptr_node != NULL)
dns_db_detachnode(ldapdb, &ptr_node);
--
2.1.0
From be242e95cd25b117d3e90e583103911128a33dab Mon Sep 17 00:00:00 2001
From: Petr Spacek <pspa...@redhat.com>
Date: Mon, 18 May 2015 14:49:10 +0200
Subject: [PATCH] Silence warning about dead assignment.
---
src/fs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/fs.c b/src/fs.c
index 174ea01b72fa7542e6b89b2311d492201996eac7..64ff15af3768c6754fc6498cbe0038d852b9e431 100644
--- a/src/fs.c
+++ b/src/fs.c
@@ -65,9 +65,7 @@ fs_dir_create(const char *dir_name)
* I don't want to change umask for all threads or add locking
* solely for this purpose. */
ret = chmod(dir_name, dir_mode);
- if (ret == 0)
- result = ISC_R_SUCCESS;
- else {
+ if (ret != 0) {
result = isc__errno2result(errno);
log_error_r("unable to chmod directory '%s', "
"working directory is '%s'",
--
2.1.0
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
