Re: [Freeipa-devel] [PATCH 0367] winsync: Add inetUser objectclass to the passsync sysaccount

2015-09-16 Thread Tomas Babej 


On 09/16/2015 03:17 PM, Petr Vobornik wrote:
> On 09/15/2015 11:37 AM, Tomas Babej wrote:
>>
>>
>> On 09/15/2015 11:30 AM, Tomas Babej wrote:
>>> Hi,
>>>
>>> attached patch fixes:
>>>
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1262315
>>>
>>> Tomas
>>>
>>>
>>>
>>
>> The previous version is for ipa-4-2, attaching a patch for master as
>> well.
>>
>> Tomas
>>
> 
> The update file should be added to makefile.am
> 

Right, fixed patches attached.
From 6486c7d1f83b5ff07de46c99c6e81009db543c03 Mon Sep 17 00:00:00 2001
From: Tomas Babej 
Date: Tue, 15 Sep 2015 11:28:18 +0200
Subject: [PATCH] winsync: Add inetUser objectclass to the passsync sysaccount

https://bugzilla.redhat.com/show_bug.cgi?id=1262315
---
 install/updates/73-winsync.update | 3 +++
 install/updates/Makefile.am   | 1 +
 ipaserver/install/replication.py  | 2 +-
 3 files changed, 5 insertions(+), 1 deletion(-)
 create mode 100644 install/updates/73-winsync.update

diff --git a/install/updates/73-winsync.update b/install/updates/73-winsync.update
new file mode 100644
index ..538eaa1cb6f97a73bfaadd61ac2ce9e9137739cf
--- /dev/null
+++ b/install/updates/73-winsync.update
@@ -0,0 +1,3 @@
+# Add a inetUser objectclass to the passsync user
+dn: uid=passsync,cn=sysaccounts,cn=etc,$SUFFIX
+addifexist: objectClass: inetUser
diff --git a/install/updates/Makefile.am b/install/updates/Makefile.am
index 2693e4f8f81dc1464a43041e5104ea4363440933..1f4a91c9bb4222f99ad7a7ad16e376aeef7f525b 100644
--- a/install/updates/Makefile.am
+++ b/install/updates/Makefile.am
@@ -51,6 +51,7 @@ app_DATA =\
 	62-ranges.update		\
 	71-idviews.update		\
 	72-domainlevels.update		\
+	73-winsync.update		\
 	90-post_upgrade_plugins.update	\
 	$(NULL)
 
diff --git a/ipaserver/install/replication.py b/ipaserver/install/replication.py
index 2b36a5eb9287bf1789009a3198e540e333869e98..4bd3849e5e91c7251856362891f6c8848da43448 100644
--- a/ipaserver/install/replication.py
+++ b/ipaserver/install/replication.py
@@ -565,7 +565,7 @@ class ReplicationManager(object):
 print "Adding Windows PassSync system account"
 entry = conn.make_entry(
 pass_dn,
-objectclass=["account", "simplesecurityobject"],
+objectclass=["account", "simplesecurityobject", "inetUser"],
 uid=["passsync"],
 userPassword=[password],
 )
-- 
2.1.0

From 58c18521c2b5ceb6a1e43406509493b93002fcf5 Mon Sep 17 00:00:00 2001
From: Tomas Babej 
Date: Tue, 15 Sep 2015 11:28:18 +0200
Subject: [PATCH] winsync: Add inetUser objectclass to the passsync sysaccount

https://bugzilla.redhat.com/show_bug.cgi?id=1262315
---
 install/updates/73-winsync.update | 3 +++
 install/updates/Makefile.am   | 1 +
 ipaserver/install/replication.py  | 2 +-
 3 files changed, 5 insertions(+), 1 deletion(-)
 create mode 100644 install/updates/73-winsync.update

diff --git a/install/updates/73-winsync.update b/install/updates/73-winsync.update
new file mode 100644
index ..538eaa1cb6f97a73bfaadd61ac2ce9e9137739cf
--- /dev/null
+++ b/install/updates/73-winsync.update
@@ -0,0 +1,3 @@
+# Add a inetUser objectclass to the passsync user
+dn: uid=passsync,cn=sysaccounts,cn=etc,$SUFFIX
+addifexist: objectClass: inetUser
diff --git a/install/updates/Makefile.am b/install/updates/Makefile.am
index 2693e4f8f81dc1464a43041e5104ea4363440933..1f4a91c9bb4222f99ad7a7ad16e376aeef7f525b 100644
--- a/install/updates/Makefile.am
+++ b/install/updates/Makefile.am
@@ -51,6 +51,7 @@ app_DATA =\
 	62-ranges.update		\
 	71-idviews.update		\
 	72-domainlevels.update		\
+	73-winsync.update		\
 	90-post_upgrade_plugins.update	\
 	$(NULL)
 
diff --git a/ipaserver/install/replication.py b/ipaserver/install/replication.py
index aa2edd1722d46637cdec461daf65188ec3ab196b..173f9696deb21d1ba768dfdfbda3c76aac5447e6 100644
--- a/ipaserver/install/replication.py
+++ b/ipaserver/install/replication.py
@@ -567,7 +567,7 @@ class ReplicationManager(object):
 print("Adding Windows PassSync system account")
 entry = conn.make_entry(
 pass_dn,
-objectclass=["account", "simplesecurityobject"],
+objectclass=["account", "simplesecurityobject", "inetUser"],
 uid=["passsync"],
 userPassword=[password],
 )
-- 
2.1.0

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0367] winsync: Add inetUser objectclass to the passsync sysaccount

2015-09-16 Thread Petr Vobornik 

On 09/15/2015 11:37 AM, Tomas Babej wrote:



On 09/15/2015 11:30 AM, Tomas Babej wrote:

Hi,

attached patch fixes:

https://bugzilla.redhat.com/show_bug.cgi?id=1262315

Tomas





The previous version is for ipa-4-2, attaching a patch for master as well.

Tomas



The update file should be added to makefile.am

--
Petr Vobornik

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0367] winsync: Add inetUser objectclass to the passsync sysaccount

2015-09-16 Thread Petr Vobornik 

On 09/16/2015 03:22 PM, Tomas Babej wrote:



On 09/16/2015 03:17 PM, Petr Vobornik wrote:

On 09/15/2015 11:37 AM, Tomas Babej wrote:



On 09/15/2015 11:30 AM, Tomas Babej wrote:

Hi,

attached patch fixes:

https://bugzilla.redhat.com/show_bug.cgi?id=1262315

Tomas





The previous version is for ipa-4-2, attaching a patch for master as
well.

Tomas



The update file should be added to makefile.am



Right, fixed patches attached.



ACK

Pushed to master: 73c82d00736ae032465b7e50a2ea51ad753c8093
Pushed to ipa-4-2: ffb676511054e72b05b25a8f339a15da5b40eb2f
--
Petr Vobornik

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH 0367] winsync: Add inetUser objectclass to the passsync sysaccount

2015-09-15 Thread Tomas Babej 
Hi,

attached patch fixes:

https://bugzilla.redhat.com/show_bug.cgi?id=1262315

Tomas
From 33efad1eb25402fe802a7584870755215f0bfa14 Mon Sep 17 00:00:00 2001
From: Tomas Babej 
Date: Tue, 15 Sep 2015 11:28:18 +0200
Subject: [PATCH] winsync: Add inetUser objectclass to the passsync sysaccount

https://bugzilla.redhat.com/show_bug.cgi?id=1262315
---
 install/updates/73-winsync.update | 3 +++
 ipaserver/install/replication.py  | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100644 install/updates/73-winsync.update

diff --git a/install/updates/73-winsync.update b/install/updates/73-winsync.update
new file mode 100644
index ..538eaa1cb6f97a73bfaadd61ac2ce9e9137739cf
--- /dev/null
+++ b/install/updates/73-winsync.update
@@ -0,0 +1,3 @@
+# Add a inetUser objectclass to the passsync user
+dn: uid=passsync,cn=sysaccounts,cn=etc,$SUFFIX
+addifexist: objectClass: inetUser
diff --git a/ipaserver/install/replication.py b/ipaserver/install/replication.py
index 2b36a5eb9287bf1789009a3198e540e333869e98..4bd3849e5e91c7251856362891f6c8848da43448 100644
--- a/ipaserver/install/replication.py
+++ b/ipaserver/install/replication.py
@@ -565,7 +565,7 @@ class ReplicationManager(object):
 print "Adding Windows PassSync system account"
 entry = conn.make_entry(
 pass_dn,
-objectclass=["account", "simplesecurityobject"],
+objectclass=["account", "simplesecurityobject", "inetUser"],
 uid=["passsync"],
 userPassword=[password],
 )
-- 
2.1.0

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0367] winsync: Add inetUser objectclass to the passsync sysaccount

2015-09-15 Thread Tomas Babej 


On 09/15/2015 11:30 AM, Tomas Babej wrote:
> Hi,
> 
> attached patch fixes:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1262315
> 
> Tomas
> 
> 
> 

The previous version is for ipa-4-2, attaching a patch for master as well.

Tomas
From 5a86506d3601e8b6405237afa619ee083572cbc1 Mon Sep 17 00:00:00 2001
From: Tomas Babej 
Date: Tue, 15 Sep 2015 11:28:18 +0200
Subject: [PATCH] winsync: Add inetUser objectclass to the passsync sysaccount

https://bugzilla.redhat.com/show_bug.cgi?id=1262315
---
 install/updates/73-winsync.update | 3 +++
 ipaserver/install/replication.py  | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100644 install/updates/73-winsync.update

diff --git a/install/updates/73-winsync.update b/install/updates/73-winsync.update
new file mode 100644
index ..538eaa1cb6f97a73bfaadd61ac2ce9e9137739cf
--- /dev/null
+++ b/install/updates/73-winsync.update
@@ -0,0 +1,3 @@
+# Add a inetUser objectclass to the passsync user
+dn: uid=passsync,cn=sysaccounts,cn=etc,$SUFFIX
+addifexist: objectClass: inetUser
diff --git a/ipaserver/install/replication.py b/ipaserver/install/replication.py
index aa2edd1722d46637cdec461daf65188ec3ab196b..173f9696deb21d1ba768dfdfbda3c76aac5447e6 100644
--- a/ipaserver/install/replication.py
+++ b/ipaserver/install/replication.py
@@ -567,7 +567,7 @@ class ReplicationManager(object):
 print("Adding Windows PassSync system account")
 entry = conn.make_entry(
 pass_dn,
-objectclass=["account", "simplesecurityobject"],
+objectclass=["account", "simplesecurityobject", "inetUser"],
 uid=["passsync"],
 userPassword=[password],
 )
-- 
2.1.0

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code