Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

2015-12-13 Thread Tomas Babej
On 12/10/2015 09:05 AM, Lukas Slebodnik wrote: > On (08/12/15 14:47), Tomas Babej wrote: >> >> >> On 12/03/2015 04:33 PM, Tomas Babej wrote: >>> >>> >>> On 12/03/2015 04:26 PM, Aleš Mareček wrote: Hello, ACK for code NACK for the placing "get_client_ip_with_hostmask" function

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

2015-12-11 Thread Lukas Slebodnik
On (10/12/15 11:40), Tomas Babej wrote: >On 12/10/2015 09:05 AM, Lukas Slebodnik wrote: >> On (08/12/15 14:47), Tomas Babej wrote: >>> >>> >>> On 12/03/2015 04:33 PM, Tomas Babej wrote: On 12/03/2015 04:26 PM, Aleš Mareček wrote: > Hello, > > ACK for code > NACK for

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

2015-12-11 Thread Tomas Babej
On 12/11/2015 02:01 PM, Lukas Slebodnik wrote: > On (10/12/15 11:40), Tomas Babej wrote: >> On 12/10/2015 09:05 AM, Lukas Slebodnik wrote: >>> On (08/12/15 14:47), Tomas Babej wrote: On 12/03/2015 04:33 PM, Tomas Babej wrote: > > > On 12/03/2015 04:26 PM, Aleš Mareček

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

2015-12-10 Thread Lukas Slebodnik
On (08/12/15 14:47), Tomas Babej wrote: > > >On 12/03/2015 04:33 PM, Tomas Babej wrote: >> >> >> On 12/03/2015 04:26 PM, Aleš Mareček wrote: >>> Hello, >>> >>> ACK for code >>> NACK for the placing "get_client_ip_with_hostmask" function to test_sudo.py >>> (this function should be in some more

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

2015-12-08 Thread Tomas Babej
On 12/03/2015 04:33 PM, Tomas Babej wrote: > > > On 12/03/2015 04:26 PM, Aleš Mareček wrote: >> Hello, >> >> ACK for code >> NACK for the placing "get_client_ip_with_hostmask" function to test_sudo.py >> (this function should be in some more general file) >> > > What place would you propose?

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

2015-12-03 Thread Lukas Slebodnik
On (03/12/15 11:35), Tomas Babej wrote: > > >On 12/02/2015 05:25 PM, Lukas Slebodnik wrote: >> On (02/12/15 15:41), Tomas Babej wrote: >>> >>> >>> On 12/02/2015 09:24 AM, Tomas Babej wrote: On 12/01/2015 06:27 PM, Tomas Babej wrote: > > > On 11/30/2015 05:32 PM, Lukas

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

2015-12-03 Thread Tomas Babej
On 12/02/2015 05:25 PM, Lukas Slebodnik wrote: > On (02/12/15 15:41), Tomas Babej wrote: >> >> >> On 12/02/2015 09:24 AM, Tomas Babej wrote: >>> >>> >>> On 12/01/2015 06:27 PM, Tomas Babej wrote: On 11/30/2015 05:32 PM, Lukas Slebodnik wrote: > On (30/11/15 13:09), Tomas Babej

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

2015-12-03 Thread Oleg Fayans
Hi Tomas, I would prefer get_client_ip_with_hostmask function to go to ipatests/test_integration/tasks.py, and to be more generic: we probably will need to run it against an arbitrary host. The rest looks fine On 12/03/2015 11:35 AM, Tomas Babej wrote: On 12/02/2015 05:25 PM, Lukas

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

2015-12-03 Thread Tomas Babej
On 12/03/2015 04:26 PM, Aleš Mareček wrote: > Hello, > > ACK for code > NACK for the placing "get_client_ip_with_hostmask" function to test_sudo.py > (this function should be in some more general file) > What place would you propose? The task.py is not a good place, as this is not really a

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

2015-12-03 Thread Aleš Mareček
Thursday, December 3, 2015 3:32:46 PM > Subject: Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for > sudo rules validating > > Hi Tomas, > > I would prefer get_client_ip_with_hostmask function to go to > ipatests/test_integration/tasks.py, and to be

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

2015-12-02 Thread Tomas Babej
On 12/02/2015 09:24 AM, Tomas Babej wrote: > > > On 12/01/2015 06:27 PM, Tomas Babej wrote: >> >> >> On 11/30/2015 05:32 PM, Lukas Slebodnik wrote: >>> On (30/11/15 13:09), Tomas Babej wrote: Hi, IPA sudo tests worked under the assumption that the clients that are executing

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

2015-12-02 Thread Lukas Slebodnik
On (02/12/15 15:41), Tomas Babej wrote: > > >On 12/02/2015 09:24 AM, Tomas Babej wrote: >> >> >> On 12/01/2015 06:27 PM, Tomas Babej wrote: >>> >>> >>> On 11/30/2015 05:32 PM, Lukas Slebodnik wrote: On (30/11/15 13:09), Tomas Babej wrote: > Hi, > > IPA sudo tests worked under

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

2015-12-02 Thread Tomas Babej
On 12/01/2015 06:27 PM, Tomas Babej wrote: > > > On 11/30/2015 05:32 PM, Lukas Slebodnik wrote: >> On (30/11/15 13:09), Tomas Babej wrote: >>> Hi, >>> >>> IPA sudo tests worked under the assumption that the clients that >>> are executing the sudo commands have their IPs assigned within >>>

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

2015-12-01 Thread Tomas Babej
On 11/30/2015 05:32 PM, Lukas Slebodnik wrote: > On (30/11/15 13:09), Tomas Babej wrote: >> Hi, >> >> IPA sudo tests worked under the assumption that the clients that >> are executing the sudo commands have their IPs assigned within >> 255.255.255.0 hostmask. >> >> Removes this (invalid)

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

2015-11-30 Thread Lukas Slebodnik
On (30/11/15 13:09), Tomas Babej wrote: >Hi, > >IPA sudo tests worked under the assumption that the clients that >are executing the sudo commands have their IPs assigned within >255.255.255.0 hostmask. > >Removes this (invalid) assumption and adds a dynamic detection of >the hostmask of the IPA

[Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

2015-11-30 Thread Tomas Babej
Hi, IPA sudo tests worked under the assumption that the clients that are executing the sudo commands have their IPs assigned within 255.255.255.0 hostmask. Removes this (invalid) assumption and adds a dynamic detection of the hostmask of the IPA client.