Re: [Freeipa-devel] [PATCH 0399] ipa-getkeytab: Handle the possibility of not obtaining a result
On 01/27/2016 05:03 PM, Martin Babinsky wrote: > On 01/26/2016 05:48 PM, Tomas Babej wrote: >> Hi, >> >> The ldap_result operation can time out, returning a NULL result, >> which in turn causes the parsing operation to crash. >> >> https://fedorahosted.org/freeipa/ticket/5642 >> >> Tomas >> >> >> > ACK > Pushed to master: d53c2f6b806335507ffd5e78be42471b85a39bbf -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0399] ipa-getkeytab: Handle the possibility of not obtaining a result
On 01/26/2016 05:48 PM, Tomas Babej wrote: Hi, The ldap_result operation can time out, returning a NULL result, which in turn causes the parsing operation to crash. https://fedorahosted.org/freeipa/ticket/5642 Tomas ACK -- Martin^3 Babinsky -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [PATCH 0399] ipa-getkeytab: Handle the possibility of not obtaining a result
Hi, The ldap_result operation can time out, returning a NULL result, which in turn causes the parsing operation to crash. https://fedorahosted.org/freeipa/ticket/5642 Tomas From 3b4482cdd5494890a220bfd935874fa84677524c Mon Sep 17 00:00:00 2001 From: Tomas BabejDate: Tue, 26 Jan 2016 17:32:29 +0100 Subject: [PATCH] ipa-getkeytab: Handle the possibility of not obtaining a result The ldap_result operation can time out, returning a NULL result, which in turn causes the parsing operation to crash. https://fedorahosted.org/freeipa/ticket/5642 --- ipa-client/ipa-getkeytab.c | 4 1 file changed, 4 insertions(+) diff --git a/ipa-client/ipa-getkeytab.c b/ipa-client/ipa-getkeytab.c index 3592d9970412e91fa62b6ca8310a9511c4235656..d4925865393ea19705d5d9ae09847966402fd8f0 100644 --- a/ipa-client/ipa-getkeytab.c +++ b/ipa-client/ipa-getkeytab.c @@ -275,6 +275,10 @@ static int ipa_ldap_extended_op(LDAP *ld, const char *reqoid, fprintf(stderr, _("Failed to get result: %s\n"), ldap_err2string(ret)); goto done; } +else if (res == NULL) { +fprintf(stderr, _("Timeout exceeded.")); +goto done; +} ret = ldap_parse_extended_result(ld, res, , , 0); if (ret != LDAP_SUCCESS) { -- 2.5.0 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0399] ipa-getkeytab: Handle the possibility of not obtaining a result
On Tue, 2016-01-26 at 17:48 +0100, Tomas Babej wrote: > Hi, > > The ldap_result operation can time out, returning a NULL result, > which in turn causes the parsing operation to crash. > > https://fedorahosted.org/freeipa/ticket/5642 > > Tomas > -- > Manage your subscription for the Freeipa-devel mailing list: > https://www.redhat.com/mailman/listinfo/freeipa-devel > Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code LGTM -- Simo Sorce * Red Hat, Inc * New York -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code