Re: [Freeipa-devel] [PATCH 0557] DNS: fix update-system-records unpacking error

2016-07-22 Thread Martin Basti



On 22.07.2016 15:12, Nikhil Dehadrai wrote:

ACK.

On 07/22/2016 05:09 PM, Martin Basti wrote:

https://fedorahosted.org/freeipa/ticket/6117

Patch attached






Thanks

Pushed to master: 524719f420fa331b3a1d53d5d8bebdfee39c8371

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0557] DNS: fix update-system-records unpacking error

2016-07-22 Thread Nikhil Dehadrai

ACK.

On 07/22/2016 05:09 PM, Martin Basti wrote:

https://fedorahosted.org/freeipa/ticket/6117

Patch attached





-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH 0557] DNS: fix update-system-records unpacking error

2016-07-22 Thread Martin Basti

https://fedorahosted.org/freeipa/ticket/6117

Patch attached

From dddbb97def78d6888b7127ab342d7d1fdc9856ad Mon Sep 17 00:00:00 2001
From: Martin Basti 
Date: Fri, 22 Jul 2016 13:32:31 +0200
Subject: [PATCH] DNS Locations: fix update-system-records unpacking error

Method IPASystemRecords.records_list_from_node returns only list
consists only from record names not tuple, which caused unpacking error

https://fedorahosted.org/freeipa/ticket/6117
---
 ipaserver/install/bindinstance.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ipaserver/install/bindinstance.py b/ipaserver/install/bindinstance.py
index 844fb04a9d9feca936211964b75a0b3468ba663b..7538e145cbe37dfc21963d97dea0e835e3bd5072 100644
--- a/ipaserver/install/bindinstance.py
+++ b/ipaserver/install/bindinstance.py
@@ -1139,10 +1139,10 @@ class BindInstance(service.Service):
 root_logger.error("Update of following records failed:")
 for attr in (failed_ipa_rec, failed_loc_rec):
 for rname, node, error in attr:
-for record, e in IPASystemRecords.records_list_from_node(
+for record in IPASystemRecords.records_list_from_node(
 rname, node
 ):
-root_logger.error("%s (%s)", record, e)
+root_logger.error("%s (%s)", record, error)
 
 def check_global_configuration(self):
 """
-- 
2.5.5

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code