Re: [Freeipa-devel] [PATCH 492] config: allow user/host attributes with tagging options

2015-09-16 Thread Jan Cholasta

On 16.9.2015 14:32, David Kupka wrote:

On 16/09/15 11:01, Jan Cholasta wrote:

Hi,

the attached patch fixes .

Honza




Works for me, ACK.



Pushed to:
master: 60dd90cf77097cd305f9cad4b03d28f2977dd38b
ipa-4-2: bbcbbf3480fb30a7f963d6083a656cc19b8a7ed6

--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


Re: [Freeipa-devel] [PATCH 492] config: allow user/host attributes with tagging options

2015-09-16 Thread David Kupka

On 16/09/15 11:01, Jan Cholasta wrote:

Hi,

the attached patch fixes .

Honza




Works for me, ACK.

--
David Kupka

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


[Freeipa-devel] [PATCH 492] config: allow user/host attributes with tagging options

2015-09-16 Thread Jan Cholasta

Hi,

the attached patch fixes .

Honza

--
Jan Cholasta
From 78b18ccabfd5acc680d9feb002400d5fe9533671 Mon Sep 17 00:00:00 2001
From: Jan Cholasta 
Date: Wed, 16 Sep 2015 08:24:22 +0200
Subject: [PATCH] config: allow user/host attributes with tagging options

https://fedorahosted.org/freeipa/ticket/5295
---
 ipalib/plugins/config.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ipalib/plugins/config.py b/ipalib/plugins/config.py
index c8153c3..f9e99a6 100644
--- a/ipalib/plugins/config.py
+++ b/ipalib/plugins/config.py
@@ -262,6 +262,7 @@ class config_mod(LDAPUpdate):
 fields = entry_attrs[k].split(',')
 for a in fields:
 a = a.strip()
+a, tomato, olive = a.partition(';')
 if a not in allowed_attrs:
 raise errors.ValidationError(
 name=k, error=_('attribute "%s" not allowed') % a
@@ -281,6 +282,7 @@ class config_mod(LDAPUpdate):
 if self.api.Object[obj].uuid_attribute:
 checked_attrs = checked_attrs + [self.api.Object[obj].uuid_attribute]
 for obj_attr in checked_attrs:
+obj_attr, tomato, olive = obj_attr.partition(';')
 if obj_attr in OPERATIONAL_ATTRIBUTES:
 continue
 if obj_attr in self.api.Object[obj].params and \
-- 
2.4.3

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code