Re: [Freeipa-devel] [PATCHES] [bind-dyndb-ldap] Two patches for minor Coverity issues

2011-01-05 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/05/2011 05:00 AM, Adam Tkac wrote: > On Tue, Jan 04, 2011 at 03:41:12PM -0500, Stephen Gallagher wrote: > Patch 0001: Fix missing varargs cleanup > > The CHECK() macro may cause execution to skip down to the cleanup > tag. If this happens, it wo

Re: [Freeipa-devel] [PATCHES] [bind-dyndb-ldap] Two patches for minor Coverity issues

2011-01-05 Thread Adam Tkac
On Tue, Jan 04, 2011 at 03:41:12PM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Patch 0001: Fix missing varargs cleanup > > The CHECK() macro may cause execution to skip down to the cleanup > tag. If this happens, it would mean that we never called va_end(

[Freeipa-devel] [PATCHES] [bind-dyndb-ldap] Two patches for minor Coverity issues

2011-01-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Patch 0001: Fix missing varargs cleanup The CHECK() macro may cause execution to skip down to the cleanup tag. If this happens, it would mean that we never called va_end() on "backup". This patch reorganizes the code slightly to ensure that va_end()