Re: [Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Jan Cholasta
On 29.2.2012 15:50, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden wrote: Petr Viktorin wrote: Patch 16 defers validation conversion until after {add,del,set}attr is processed, so that we don't search for an integer in a list of strings (this caused ticket

Re: [Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Rob Crittenden
Jan Cholasta wrote: On 29.2.2012 15:50, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden wrote: Petr Viktorin wrote: Patch 16 defers validation conversion until after {add,del,set}attr is processed, so that we don't search for an integer in a list of strings

Re: [Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Petr Viktorin
I may be taking things out of context, but I see this: On 03/16/2012 02:07 PM, Rob Crittenden wrote: Jan Cholasta wrote: On 29.2.2012 15:50, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden wrote: .. snip .. Patch 17 makes these options honor params marked

Re: [Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Jan Cholasta
On 16.3.2012 14:14, Petr Viktorin wrote: I may be taking things out of context, but I see this: On 03/16/2012 02:07 PM, Rob Crittenden wrote: Jan Cholasta wrote: On 29.2.2012 15:50, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden wrote: .. snip .. Patch

Re: [Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Rob Crittenden
Petr Viktorin wrote: I may be taking things out of context, but I see this: On 03/16/2012 02:07 PM, Rob Crittenden wrote: Jan Cholasta wrote: On 29.2.2012 15:50, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden wrote: .. snip .. Patch 17 makes these

Re: [Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-03-16 Thread Petr Viktorin
On 03/16/2012 02:34 PM, Rob Crittenden wrote: Petr Viktorin wrote: I may be taking things out of context, but I see this: On 03/16/2012 02:07 PM, Rob Crittenden wrote: Jan Cholasta wrote: On 29.2.2012 15:50, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden

Re: [Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-02-29 Thread Petr Viktorin
On 02/27/2012 11:03 PM, Rob Crittenden wrote: Petr Viktorin wrote: Patch 16 defers validation conversion until after {add,del,set}attr is processed, so that we don't search for an integer in a list of strings (this caused ticket #2405), and so that the end result of these operations is

Re: [Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-02-29 Thread Rob Crittenden
Petr Viktorin wrote: On 02/27/2012 11:03 PM, Rob Crittenden wrote: Petr Viktorin wrote: Patch 16 defers validation conversion until after {add,del,set}attr is processed, so that we don't search for an integer in a list of strings (this caused ticket #2405), and so that the end result of these

[Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-02-27 Thread Petr Viktorin
Patch 16 defers validation conversion until after {add,del,set}attr is processed, so that we don't search for an integer in a list of strings (this caused ticket #2405), and so that the end result of these operations is validated (#2407). Patch 17 makes these options honor params marked

Re: [Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-02-27 Thread Rob Crittenden
Petr Viktorin wrote: Patch 16 defers validation conversion until after {add,del,set}attr is processed, so that we don't search for an integer in a list of strings (this caused ticket #2405), and so that the end result of these operations is validated (#2407). Patch 17 makes these options