Re: [Freeipa-devel] [PATCHES] 0508-0509 Add support for "non-object" managed permissions

2014-04-09 Thread Petr Viktorin
On 04/09/2014 10:31 AM, Martin Kosek wrote: On 04/08/2014 05:17 PM, Petr Viktorin wrote: On 04/08/2014 04:39 PM, Martin Kosek wrote: On 04/08/2014 01:14 PM, Petr Viktorin wrote: On 04/08/2014 12:53 PM, Martin Kosek wrote: On 04/08/2014 11:03 AM, Petr Viktorin wrote: ... The patch is functio

Re: [Freeipa-devel] [PATCHES] 0508-0509 Add support for "non-object" managed permissions

2014-04-09 Thread Martin Kosek
On 04/08/2014 05:17 PM, Petr Viktorin wrote: > On 04/08/2014 04:39 PM, Martin Kosek wrote: >> On 04/08/2014 01:14 PM, Petr Viktorin wrote: >>> On 04/08/2014 12:53 PM, Martin Kosek wrote: On 04/08/2014 11:03 AM, Petr Viktorin wrote: >> ... The patch is functional, but I am not really a big

Re: [Freeipa-devel] [PATCHES] 0508-0509 Add support for "non-object" managed permissions

2014-04-08 Thread Petr Viktorin
On 04/08/2014 04:39 PM, Martin Kosek wrote: On 04/08/2014 01:14 PM, Petr Viktorin wrote: On 04/08/2014 12:53 PM, Martin Kosek wrote: On 04/08/2014 11:03 AM, Petr Viktorin wrote: ... The patch is functional, but I am not really a big fan of placing it in the plugin. I would prefer if the ACI d

Re: [Freeipa-devel] [PATCHES] 0508-0509 Add support for "non-object" managed permissions

2014-04-08 Thread Martin Kosek
On 04/08/2014 01:14 PM, Petr Viktorin wrote: > On 04/08/2014 12:53 PM, Martin Kosek wrote: >> On 04/08/2014 11:03 AM, Petr Viktorin wrote: ... >> The patch is functional, but I am not really a big fan of placing it in the >> plugin. I would prefer if the ACI definition is also in the sudo plugin >>

Re: [Freeipa-devel] [PATCHES] 0508-0509 Add support for "non-object" managed permissions

2014-04-08 Thread Petr Viktorin
On 04/08/2014 12:53 PM, Martin Kosek wrote: On 04/08/2014 11:03 AM, Petr Viktorin wrote: Patch 0508: This documents the inputs for the permission updater in the module itself. This is taken from the design page. I expect it'll need an addition now and then, so I think it's better to have this n

Re: [Freeipa-devel] [PATCHES] 0508-0509 Add support for "non-object" managed permissions

2014-04-08 Thread Martin Kosek
On 04/08/2014 11:03 AM, Petr Viktorin wrote: > > Patch 0508: > This documents the inputs for the permission updater in the module itself. > This > is taken from the design page. I expect it'll need an addition now and then, > so > I think it's better to have this near the code it corresponds to.

[Freeipa-devel] [PATCHES] 0508-0509 Add support for "non-object" managed permissions

2014-04-08 Thread Petr Viktorin
Patch 0508: This documents the inputs for the permission updater in the module itself. This is taken from the design page. I expect it'll need an addition now and then, so I think it's better to have this near the code it corresponds to. Patch 0509: So far the new default permissions have b