Re: [Freeipa-devel] [PATCHES] 152-158 ipa-server-certinstall fixes

2013-08-20 Thread Jan Cholasta
On 19.8.2013 17:53, Petr Viktorin wrote: On 08/19/2013 03:50 PM, Jan Cholasta wrote: On 19.8.2013 14:02, Petr Viktorin wrote: Thanks! I've read the patches and have some initial comments; I'll get to functional testing (and writing related CA-less tests) right away. The patches need a small

Re: [Freeipa-devel] [PATCHES] 152-158 ipa-server-certinstall fixes

2013-08-20 Thread Petr Viktorin
On 08/20/2013 09:10 AM, Jan Cholasta wrote: On 19.8.2013 17:53, Petr Viktorin wrote: On 08/19/2013 03:50 PM, Jan Cholasta wrote: On 19.8.2013 14:02, Petr Viktorin wrote: Thanks! I've read the patches and have some initial comments; I'll get to functional testing (and writing related CA-less

Re: [Freeipa-devel] [PATCHES] 152-158 ipa-server-certinstall fixes

2013-08-19 Thread Petr Viktorin
On 07/15/2013 10:16 AM, Jan Cholasta wrote: On 11.7.2013 14:10, Jan Cholasta wrote: Hi, this is the first batch of patches for https://fedorahosted.org/freeipa/ticket/3641. It contains port of ipa-server-certinstall to the admintool framework and fixes some bugs. Note that there's still some

Re: [Freeipa-devel] [PATCHES] 152-158 ipa-server-certinstall fixes

2013-08-19 Thread Jan Cholasta
On 19.8.2013 14:02, Petr Viktorin wrote: Thanks! I've read the patches and have some initial comments; I'll get to functional testing (and writing related CA-less tests) right away. The patches need a small rebase (attached since I did it anyway). Patch 152: OK (I saw some issues but they're

Re: [Freeipa-devel] [PATCHES] 152-158 ipa-server-certinstall fixes

2013-08-19 Thread Petr Viktorin
On 08/19/2013 03:50 PM, Jan Cholasta wrote: On 19.8.2013 14:02, Petr Viktorin wrote: Thanks! I've read the patches and have some initial comments; I'll get to functional testing (and writing related CA-less tests) right away. The patches need a small rebase (attached since I did it anyway).

[Freeipa-devel] [PATCHES] 152-158 ipa-server-certinstall fixes

2013-07-15 Thread Jan Cholasta
On 11.7.2013 14:10, Jan Cholasta wrote: Hi, this is the first batch of patches for https://fedorahosted.org/freeipa/ticket/3641. It contains port of ipa-server-certinstall to the admintool framework and fixes some bugs. Note that there's still some work I have to do to make