Re: [Freeipa-devel] [PATCHES 0172-0176] ipa_range_check improvements

2014-04-23 Thread Tomas Babej
On 04/22/2014 12:50 PM, Tomas Babej wrote: On 04/17/2014 02:44 PM, Alexander Bokovoy wrote: You replace this by range-base_rid_set = (slapi_entry_attr_find(entry, IPA_BASE_RID, attr) == -1); You probably meant == 0. Fixed. I know that is was in your original code, but can we get

Re: [Freeipa-devel] [PATCHES 0172-0176] ipa_range_check improvements

2014-04-23 Thread Martin Kosek
On 04/23/2014 12:50 PM, Tomas Babej wrote: On 04/22/2014 12:50 PM, Tomas Babej wrote: On 04/17/2014 02:44 PM, Alexander Bokovoy wrote: You replace this by range-base_rid_set = (slapi_entry_attr_find(entry, IPA_BASE_RID, attr) == -1); You probably meant == 0. Fixed. I know that is

Re: [Freeipa-devel] [PATCHES 0172-0176] ipa_range_check improvements

2014-04-22 Thread Tomas Babej
On 04/17/2014 02:44 PM, Alexander Bokovoy wrote: You replace this by range-base_rid_set = (slapi_entry_attr_find(entry, IPA_BASE_RID, attr) == -1); You probably meant == 0. Fixed. I know that is was in your original code, but can we get numbers replaced by an enum? I'd prefer to see

[Freeipa-devel] [PATCHES 0172-0176] ipa_range_check improvements

2014-04-17 Thread Tomas Babej
Hi, This set of patches deals with bugs and extensions of ipa_range_check plugin. See commit messages for details. Parts of: https://fedorahosted.org/freeipa/ticket/4137 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org

Re: [Freeipa-devel] [PATCHES 0172-0176] ipa_range_check improvements

2014-04-17 Thread Alexander Bokovoy
On Thu, 17 Apr 2014, Tomas Babej wrote: From 43cd26a0a42c3b18e4dbb5c6ed0f20ee1562b98a Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Wed, 16 Apr 2014 17:15:55 +0200 Subject: [PATCH] ipa_range_check: Use special attributes to determine presence of RID bases The

Re: [Freeipa-devel] [PATCHES 0172-0176] ipa_range_check improvements

2014-04-17 Thread Alexander Bokovoy
On Thu, 17 Apr 2014, Tomas Babej wrote: From d714f77f1f162d1c7daeecf7a340f95ed3368f2d Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Wed, 16 Apr 2014 17:20:55 +0200 Subject: [PATCH] ipa_range_check: Connect the new node of the linked list Part of:

Re: [Freeipa-devel] [PATCHES 0172-0176] ipa_range_check improvements

2014-04-17 Thread Alexander Bokovoy
On Thu, 17 Apr 2014, Tomas Babej wrote: From 632c0ed1fca2cb48b981f6daac55badd59c9c263 Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Wed, 16 Apr 2014 17:22:46 +0200 Subject: [PATCH] ipa_range_check: Make a new copy of forest_root_id attribute for range_info struct Not

Re: [Freeipa-devel] [PATCHES 0172-0176] ipa_range_check improvements

2014-04-17 Thread Alexander Bokovoy
On Thu, 17 Apr 2014, Tomas Babej wrote: From ed60bd0e865aad85eb1ffa02d8aea7f76220c65c Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Wed, 16 Apr 2014 17:26:07 +0200 Subject: [PATCH] ipa_range_check: Do not fail when no trusted domain is available When building the domain to

Re: [Freeipa-devel] [PATCHES 0172-0176] ipa_range_check improvements

2014-04-17 Thread Alexander Bokovoy
On Thu, 17 Apr 2014, Tomas Babej wrote: From 96f27c06f062dcfaa40405c50ad087d6013dc62c Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Wed, 16 Apr 2014 17:28:34 +0200 Subject: [PATCH] ipa_range_check: Fix typo when comparing strings using strcasecmp Part of: