Re: [Freeipa-devel] [TEST][Patch 0022] small refactoring in integration tests due to BZ 1303095

2016-03-02 Thread Martin Basti
On 01.03.2016 15:22, Milan Kubík wrote: On 02/19/2016 02:11 PM, Oleg Fayans wrote: Hi Milan, On 02/12/2016 04:03 PM, Milan Kubík wrote: Agreed. The latest patch gets rid of all resolv.conf related manipulations. The tests work (where not affected by

Re: [Freeipa-devel] [TEST][Patch 0022] small refactoring in integration tests due to BZ 1303095

2016-03-01 Thread Milan Kubík
On 02/19/2016 02:11 PM, Oleg Fayans wrote: Hi Milan, On 02/12/2016 04:03 PM, Milan Kubík wrote: Agreed. The latest patch gets rid of all resolv.conf related manipulations. The tests work (where not affected by https://fedorahosted.org/bind-dyndb-ldap/ticket/160) -- Milan Kubik Works for

Re: [Freeipa-devel] [TEST][Patch 0022] small refactoring in integration tests due to BZ 1303095

2016-02-12 Thread Milan Kubík
On 02/04/2016 08:49 AM, Oleg Fayans wrote: Hi Petr, On 02/03/2016 02:19 PM, Petr Spacek wrote: On 3.2.2016 10:22, Oleg Fayans wrote: Guys, can anyone take a look at this? The commit message does not explain why you are setting search path. Fixed. I have to say that I do not like touching

Re: [Freeipa-devel] [TEST][Patch 0022] small refactoring in integration tests due to BZ 1303095

2016-02-03 Thread Oleg Fayans
Guys, can anyone take a look at this? On 01/29/2016 04:09 PM, Oleg Fayans wrote: > > > -- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [TEST][Patch 0022] small refactoring in integration tests due to BZ 1303095

2016-02-03 Thread Oleg Fayans
Hi Petr, On 02/03/2016 02:19 PM, Petr Spacek wrote: > On 3.2.2016 10:22, Oleg Fayans wrote: >> Guys, can anyone take a look at this? > > The commit message does not explain why you are setting search path. Fixed. > > I have to say that I do not like touching resolv.conf, as stated many times

Re: [Freeipa-devel] [TEST][Patch 0022] small refactoring in integration tests due to BZ 1303095

2016-02-03 Thread Petr Spacek
On 3.2.2016 10:22, Oleg Fayans wrote: > Guys, can anyone take a look at this? The commit message does not explain why you are setting search path. I have to say that I do not like touching resolv.conf, as stated many times earlier. Why the test has to reconfigure the host and cannot use values

[Freeipa-devel] [TEST][Patch 0022] small refactoring in integration tests due to BZ 1303095

2016-01-29 Thread Oleg Fayans
-- Oleg Fayans Quality Engineer FreeIPA team RedHat. From b866ff5336f742e170895b575df7a09419c2d731 Mon Sep 17 00:00:00 2001 From: Oleg Fayans Date: Fri, 29 Jan 2016 16:04:17 +0100 Subject: [PATCH] Moved NM configuration calls to the IntegrationTest base class Reconfiguring