[Freeipa-devel] [freeipa PR#101][comment] Improved vault-show error message
URL: https://github.com/freeipa/freeipa/pull/101 Title: #101: Improved vault-show error message stlaz commented: """ WONTFIX then. There's no winning here. """ See the full comment at https://github.com/freeipa/freeipa/pull/101#issuecomment-263265074 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#101][comment] Improved vault-show error message
URL: https://github.com/freeipa/freeipa/pull/101 Title: #101: Improved vault-show error message mbasti-rh commented: """ I had discussion with @jcholast and he disagrees. This weird handling of DN should stay isolated in vault code and shouldn't be spreaded across the framework. I'm starting to think that we should close ticket as won't/can't fix instead of doing that bad code even worse. """ See the full comment at https://github.com/freeipa/freeipa/pull/101#issuecomment-263253629 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#101][comment] Improved vault-show error message
URL: https://github.com/freeipa/freeipa/pull/101 Title: #101: Improved vault-show error message stlaz commented: """ Seems like nobody objected so far. """ See the full comment at https://github.com/freeipa/freeipa/pull/101#issuecomment-262971504 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#101][comment] Improved vault-show error message
URL: https://github.com/freeipa/freeipa/pull/101 Title: #101: Improved vault-show error message mbasti-rh commented: """ Oh realized that is not possible to create DN inside handle_not_found, because it does not take **kwargs Probably we can extend handle_not_found with kwargs, but this decision needs broader audience. """ See the full comment at https://github.com/freeipa/freeipa/pull/101#issuecomment-248728122 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#101][comment] Improved vault-show error message
URL: https://github.com/freeipa/freeipa/pull/101
Title: #101: Improved vault-show error message
mbasti-rh commented:
"""
NACK: you fixed only vault-show not other vault-* commands
NACK: I don't like the override of execute method (it should work for all
vault-* commands automatically)
Is possible to override method handle_not_found of vault object? IMO which
vault type is used can be determined by DN suffix (maybe it deserves a new
method vault_type_from_DN()).
NACK: This is pure evil, pls keep better readability (use if-elif-else instead)
```
if options.get('service'):
container_type = 'service'
else:
container_type = 'shared' if options.get('shared') else 'user'
```
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/101#issuecomment-248679160
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
