URL: https://github.com/freeipa/freeipa/pull/116
Author: Akasurde
 Title: #116: Added fix for no-hbac-allow option in server install script
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/116/head:pr116
git checkout pr116
From 5baff8faada66b530be6c84fe997fb7b18f6d646 Mon Sep 17 00:00:00 2001
From: Abhijeet Kasurde <akasu...@redhat.com>
Date: Mon, 26 Sep 2016 15:50:44 +0530
Subject: [PATCH] Add fix for no-hbac-allow option in server install

This PR brings uniformity in option provided by no-hbac-allow
and other options present in IPA server install script

Fixes https://fedorahosted.org/freeipa/ticket/6357

Signed-off-by: Abhijeet Kasurde <akasu...@redhat.com>
---
 install/tools/man/ipa-server-install.1 | 2 +-
 ipaserver/install/server/install.py    | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/install/tools/man/ipa-server-install.1 b/install/tools/man/ipa-server-install.1
index f7c1921..69316fb 100644
--- a/install/tools/man/ipa-server-install.1
+++ b/install/tools/man/ipa-server-install.1
@@ -58,7 +58,7 @@ The starting user and group id number (default random)
 \fB\-\-idmax\fR=\fIIDMAX\fR
 The maximum user and group id number (default: idstart+199999). If set to zero, the default value will be used.
 .TP
-\fB\-\-no_hbac_allow\fR
+\fB\-\-no-hbac-allow\fR
 Don't install allow_all HBAC rule. This rule lets any user from any host access any service on any other host. It is expected that users will remove this rule before moving to production.
 .TP
 \fB\-\-ignore-topology-disconnect\fR
diff --git a/ipaserver/install/server/install.py b/ipaserver/install/server/install.py
index 22328ef..0015a8c 100644
--- a/ipaserver/install/server/install.py
+++ b/ipaserver/install/server/install.py
@@ -1288,7 +1288,8 @@ def idmax(self):
     no_hbac_allow = Knob(
         bool, False,
         description="Don't install allow_all HBAC rule",
-        cli_name='no_hbac_allow',
+        cli_name='no-hbac-allow',
+        cli_aliases=['no_hbac_allow'],
     )
 
     ignore_topology_disconnect = Knob(
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to