[Freeipa-devel] [freeipa PR#117][comment] Make ipa-replica-install run in interactive mode

2017-03-10 Thread stlaz
  URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

stlaz commented:
"""
I have a WIP patch but since sometimes it's not clear which credentials are 
used, I am marking this as postponed so that we can wait until the client 
module can be called properly.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/117#issuecomment-285683404
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#117][comment] Make ipa-replica-install run in interactive mode

2016-12-15 Thread stlaz
  URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

stlaz commented:
"""
Rebase done. I wanted to wait until some more changes to api bootstrapping to 
be able to call client installation from module using the latest installer 
system from the installers refactoring but we agreed with @jcholast that it'd 
be better to do that later.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/117#issuecomment-267356755
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#117][comment] Make ipa-replica-install run in interactive mode

2016-11-22 Thread tomaskrizek
  URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

tomaskrizek commented:
"""
This PR needs to be rebased to reflect installer refactoring.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/117#issuecomment-262178290
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#117][comment] Make ipa-replica-install run in interactive mode

2016-10-17 Thread simo5
  URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

simo5 commented:
"""
@stlaz, sure, what I meant is that the checking code should be made common and 
run in ipa-repliuca-install, certainly I was not suggesting to just duplicate 
all that code. Perhaps refactoring will just do that.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/117#issuecomment-254207783
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#117][comment] Make ipa-replica-install run in interactive mode

2016-10-14 Thread stlaz
  URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

stlaz commented:
"""
@simo5: There is a LOT of checking of various combinations of options in 
ipa-client-install, not even mentioning IPADiscovery in interactive mode. It 
does not make sense to copy-paste all/most of it.
Note that this patch may be obsoleted by the installers refactoring effort as 
the ticket was moved to 4.5 release.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/117#issuecomment-253914584
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#117][comment] Make ipa-replica-install run in interactive mode

2016-10-14 Thread simo5
  URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

simo5 commented:
"""
@stlaz I do not understand the rationale. Ideally the ipa-replica-install 
command gathers all necessary info and ipa-client-install is always run in 
unattended mode.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/117#issuecomment-253868897
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#117][comment] Make ipa-replica-install run in interactive mode

2016-10-03 Thread jcholast
  URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

jcholast commented:
"""
NACK, see inline comments.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/117#issuecomment-251044036
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#117][comment] Make ipa-replica-install run in interactive mode

2016-09-29 Thread tomaskrizek
  URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

tomaskrizek commented:
"""
ACK

Running the command in interactive mode by default is desirable behaviour. 
Since the `-U` flag was present in previous versions, we don't have to worry 
about backward compatibility.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/117#issuecomment-250389651
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#117][comment] Make ipa-replica-install run in interactive mode

2016-09-27 Thread tomaskrizek
  URL: https://github.com/freeipa/freeipa/pull/117
Title: #117: Make ipa-replica-install run in interactive mode

tomaskrizek commented:
"""
NACK, please see inline comments.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/117#issuecomment-249814914
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code