[Freeipa-devel] [freeipa PR#121][comment] Pylint: enable unused-variable check

2016-09-27 Thread mbasti-rh
  URL: https://github.com/freeipa/freeipa/pull/121
Title: #121: Pylint: enable unused-variable check

mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/0f88f8fe889ae4801fc8d5ece1ad51c5246718ac
https://fedorahosted.org/freeipa/changeset/9d83be3647547cfca4e129cfeb63771213232cf7
https://fedorahosted.org/freeipa/changeset/45e3aee35219c89c07d590003a334f8db658a3b2
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/121#issuecomment-249840099
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#121][comment] Pylint: enable unused-variable check

2016-09-27 Thread stlaz
  URL: https://github.com/freeipa/freeipa/pull/121
Title: #121: Pylint: enable unused-variable check

stlaz commented:
"""
The latest changes fixed the nitpicks mentioned, ACK. Thanks :+1: 
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/121#issuecomment-249830361
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#121][comment] Pylint: enable unused-variable check

2016-09-27 Thread stlaz
  URL: https://github.com/freeipa/freeipa/pull/121
Title: #121: Pylint: enable unused-variable check

stlaz commented:
"""
The changes seem fine except for the two small nitpicks.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/121#issuecomment-249823191
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#121][comment] Pylint: enable unused-variable check

2016-09-27 Thread flo-renaud
  URL: https://github.com/freeipa/freeipa/pull/121
Title: #121: Pylint: enable unused-variable check

flo-renaud commented:
"""
Agree with you, ACK.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/121#issuecomment-249822167
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#121][comment] Pylint: enable unused-variable check

2016-09-27 Thread mbasti-rh
  URL: https://github.com/freeipa/freeipa/pull/121
Title: #121: Pylint: enable unused-variable check

mbasti-rh commented:
"""
I disagree, I really think that there should not be assert
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/121#issuecomment-249816977
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code