URL: https://github.com/freeipa/freeipa/pull/143
Title: #143: Issue6386 nss dir
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/a22a5dd676f581910ac7872c1a20322278fc7d4a
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/143
Title: #143: Issue6386 nss dir
tiran commented:
"""
No, #182 does not break ```ipa-client-install ``` in a bad way. The command
simply refuses to work in the presence of ```IPA_CONFDIR```.
```api.bootstrap()``` does not support
URL: https://github.com/freeipa/freeipa/pull/143
Title: #143: Issue6386 nss dir
jcholast commented:
"""
For example, if your `IPA_CONFDIR` PR was merged, setting the variable could
break `ipa-client-install`, because the hard coded half of it assumes that the
configuration directory is always
URL: https://github.com/freeipa/freeipa/pull/143
Title: #143: Issue6386 nss dir
tiran commented:
"""
I don't understand your comment.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/143#issuecomment-259672798
--
Manage your subscription for the Freeipa-devel mailing list:
URL: https://github.com/freeipa/freeipa/pull/143
Title: #143: Issue6386 nss dir
jcholast commented:
"""
Sure, just please keep this in mind for your other changes.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/143#issuecomment-259670294
--
Manage your subscription for
URL: https://github.com/freeipa/freeipa/pull/143
Title: #143: Issue6386 nss dir
tiran commented:
"""
The other locations are used for FreeIPA installation and therefore out of
scope for this change.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/143
Title: #143: Issue6386 nss dir
jcholast commented:
"""
OK, but you should at least make sure that where the code depends on hard-coded
paths, the API is bootstrapped with a hard coded `confdir` as well, otherwise
things might break.
"""
See
URL: https://github.com/freeipa/freeipa/pull/143
Title: #143: Issue6386 nss dir
tiran commented:
"""
I have fixed all places that don't depend on hard-coded paths. The other places
are used for client enrolment and depend on hard-coded paths for sysrestore.
Some places use the path before
URL: https://github.com/freeipa/freeipa/pull/143
Title: #143: Issue6386 nss dir
tomaskrizek commented:
"""
Functional ACK.
In the ticket, you mention other places where `paths.IPA_NSSDB_DIR` is used.
What's the reason this change affects only client plugins?
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/143
Title: #143: Issue6386 nss dir
tiran commented:
"""
Please ack.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/143#issuecomment-255664324
--
Manage your subscription for the Freeipa-devel mailing list:
URL: https://github.com/freeipa/freeipa/pull/143
Title: #143: Issue6386 nss dir
jcholast commented:
"""
NACK, see inline comments.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/143#issuecomment-254226440
--
Manage your subscription for the Freeipa-devel mailing list:
11 matches
Mail list logo