[Freeipa-devel] [freeipa PR#203][comment] Add sdist_list plugin to all setup.py

2016-11-14 Thread tiran
  URL: https://github.com/freeipa/freeipa/pull/203
Title: #203: Add sdist_list plugin to all setup.py

tiran commented:
"""
The feature is no longer required. @pspacek uses ``egg-info/SOURCES.txt``.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/203#issuecomment-260308091
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#203][comment] Add sdist_list plugin to all setup.py

2016-11-02 Thread tiran
  URL: https://github.com/freeipa/freeipa/pull/203
Title: #203: Add sdist_list plugin to all setup.py

tiran commented:
"""
It can't be done in a clean way. distutils and setuptools starts logging to 
stdout before the command has a chance to change the log level. I don't want to 
change the log level globally because it contains useful information.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/203#issuecomment-257841684
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#203][comment] Add sdist_list plugin to all setup.py

2016-11-02 Thread pspacek
  URL: https://github.com/freeipa/freeipa/pull/203
Title: #203: Add sdist_list plugin to all setup.py

pspacek commented:
"""
> There is nothing to fix here. Just use the --source-list argument.
I would rather avoid temporary file and related logic. For this reason I would 
like to see `--quiet` option propagated to subcommands. Can it be done?
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/203#issuecomment-257840453
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#203][comment] Add sdist_list plugin to all setup.py

2016-11-02 Thread tiran
  URL: https://github.com/freeipa/freeipa/pull/203
Title: #203: Add sdist_list plugin to all setup.py

tiran commented:
"""
There is nothing to fix here. Just use the ```--source-list``` argument.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/203#issuecomment-257838678
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#203][comment] Add sdist_list plugin to all setup.py

2016-11-02 Thread pspacek
  URL: https://github.com/freeipa/freeipa/pull/203
Title: #203: Add sdist_list plugin to all setup.py

pspacek commented:
"""
> 1. redirect stderr and use python setup.py --quiet sdist_list. The order is 
> import, python setup.py sdist_list --quiet only silences sdist_list command, 
> not subcommands.

Could you fix sdist_list so it properly propagates --quiet option to the 
subcommands?
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/203#issuecomment-257835229
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#203][comment] Add sdist_list plugin to all setup.py

2016-11-01 Thread tiran
  URL: https://github.com/freeipa/freeipa/pull/203
Title: #203: Add sdist_list plugin to all setup.py

tiran commented:
"""
You have two options to work around the extra output
1. redirect stderr and use ```python setup.py --quiet sdist_list```. The order 
is import, ```python setup.py sdist_list --quiet``` only silences sdist_list 
command, not subcommands.
2. use the ```--source-list``` option to write the source list into a file

The content of ```SOURCES.txt``` is not necessarily the same as 
```sdist_list```. The ```sdist``` command may add additional files after 
```egg_info``` has creates the file.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/203#issuecomment-257565973
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#203][comment] Add sdist_list plugin to all setup.py

2016-11-01 Thread pspacek
  URL: https://github.com/freeipa/freeipa/pull/203
Title: #203: Add sdist_list plugin to all setup.py

pspacek commented:
"""
Thanks for the propsal. It has several problems:
- It prints extra text at the beginning of output. This makes the output 
unsuitable for automated processing.
~~~
$ python setup.py sdist_list --quiet
running sdist_list
running egg_info
writing freeipa.egg-info/PKG-INFO
writing top-level names to freeipa.egg-info/top_level.txt
writing dependency_links to freeipa.egg-info/dependency_links.txt
reading manifest file 'freeipa.egg-info/SOURCES.txt'
writing manifest file 'freeipa.egg-info/SOURCES.txt'
warning: sdist_list: standard file not found: should have one of README, 
README.rst, README.txt

running check
/home/pspacek/pkg/ipa/git/ipaserver/__init__.py
~~~
- pylint is failing

I wonder if the printed list is always the same as *.egg-info/SOURCES.txt or 
not. If it is the same we may very well re-use that file. It seems that 
egg-info is generated during `sdist_list` processing anyway ...
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/203#issuecomment-257562968
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code