URL: https://github.com/freeipa/freeipa/pull/207
Author: Akasurde
 Title: #207: Provide user hint about IP address in IPA install
Action: opened

PR body:
"""
With this fix, user will be notified about pressing enter
to proceed with IPA installation procedure, if user has
provided valid IP address previously.

Fixes https://fedorahosted.org/freeipa/ticket/5949

Signed-off-by: Abhijeet Kasurde <akasu...@redhat.com>
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/207/head:pr207
git checkout pr207
From 27f0a980b9b077f297ff7753675c0d766cae9767 Mon Sep 17 00:00:00 2001
From: Abhijeet Kasurde <akasu...@redhat.com>
Date: Wed, 2 Nov 2016 13:33:37 +0530
Subject: [PATCH] Provide user hint about IP address in IPA install

With this fix, user will be notified about pressing enter
to proceed with IPA installation procedure, if user has
provided valid IP address previously.

Fixes https://fedorahosted.org/freeipa/ticket/5949

Signed-off-by: Abhijeet Kasurde <akasu...@redhat.com>
---
 ipaserver/install/installutils.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/ipaserver/install/installutils.py b/ipaserver/install/installutils.py
index 8111f18..6c06a22 100644
--- a/ipaserver/install/installutils.py
+++ b/ipaserver/install/installutils.py
@@ -268,8 +268,11 @@ def add_record_to_hosts(ip, host_name, conf_file=paths.HOSTS):
 def read_ip_addresses():
     ips = []
     print("Enter the IP address to use, or press Enter to finish.")
+    msg = "Please provide the IP address to be used for this host name"
     while True:
-        ip = ipautil.user_input("Please provide the IP address to be used for this host name", allow_empty = True)
+        if ips:
+            msg += " or leave blank to continue with the installation"
+        ip = ipautil.user_input(msg, allow_empty=True)
         if not ip:
             break
         try:
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to