URL: https://github.com/freeipa/freeipa/pull/209
Title: #209: Enumerate available options in IPA installer
Akasurde commented:
"""
@HonzaCholasta Thanks for your help and reviews.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/209#issuecomment-270112277
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/209
Title: #209: Enumerate available options in IPA installer
HonzaCholasta commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/80c0e5cb8d689cf1ec6a883d2c7000f9dadbf7d8
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/209
Title: #209: Enumerate available options in IPA installer
HonzaCholasta commented:
"""
Works for me, although you should probably keep the changes to `ipa-ca-install`
from the original patch (using the `argparse` format, of course).
"""
See the
URL: https://github.com/freeipa/freeipa/pull/209
Title: #209: Enumerate available options in IPA installer
jcholast commented:
"""
@Akasurde, `Knob()` already handles metavar properly, you need to work on the
interface between the installer and `optparse` - `ipapython.install.cli`.
"""
See
URL: https://github.com/freeipa/freeipa/pull/209
Title: #209: Enumerate available options in IPA installer
Akasurde commented:
"""
@jcholast @mbasti-rh I will work on modifying `Knob()` to handle metavar
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/209
Title: #209: Enumerate available options in IPA installer
jcholast commented:
"""
@mbasti-rh, I don't care as long as it's done right (i.e. without hardcoding
`cli_metavar` in knob definitions).
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/209
Title: #209: Enumerate available options in IPA installer
mbasti-rh commented:
"""
@jcholast any update? Should reject this PR and wait for `argparse` or fix it
with `optparse` as well? IMO fixing it now is better for UX, we dont know when
or
URL: https://github.com/freeipa/freeipa/pull/209
Title: #209: Enumerate available options in IPA installer
mbasti-rh commented:
"""
@jcholast I know, but it doesn't fill `metavar` with choices. I don't know when
we will migrate to argparse, so I think until that we can extend it to show
URL: https://github.com/freeipa/freeipa/pull/209
Title: #209: Enumerate available options in IPA installer
jcholast commented:
"""
@mbasti-rh: `knob()` already handles choices, it's the built-in `optparse`
module which does not display them. Once the installer code is migrated to
`argparse`,
URL: https://github.com/freeipa/freeipa/pull/209
Title: #209: Enumerate available options in IPA installer
mbasti-rh commented:
"""
Hi, we changed a lot of code during refactoring, PR doesn't apply. IMO list of
choices shown in --help should be handled in knob() if metavar is not specified
URL: https://github.com/freeipa/freeipa/pull/209
Title: #209: Enumerate available options in IPA installer
Akasurde commented:
"""
ping
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/209#issuecomment-259639629
--
Manage your subscription for the Freeipa-devel mailing
11 matches
Mail list logo
