URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/4842231074683ff68be50b147560f5383aa305b6
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
pspacek commented:
"""
@tiran You are right, I forgot to remove the `config.rpath` when
`AM_GNU_GETTEXT_VERSION` macro was introduced. This version fixes this problem
by
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
lslebodn commented:
"""
>Your patch adds `config.rpath`. Is it necessary to include the file in source
>control? certmonger and sssd use the file but don't have it in git.
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
tiran commented:
"""
Your patch adds ```config.rpath```. Is it necessary to include the file in
source control? certmonger and sssd use the file but don't have it in git.
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
pspacek commented:
"""
Good catch, fixed & rebased on top of current master.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/238#issuecomment-261467199
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
tiran commented:
"""
Build is failing:
```
Can't exec "autopoint": No such file or directory at
/usr/share/autoconf/Autom4te/FileUtils.pm line 345.
autoreconf: failed to
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
pspacek commented:
"""
As far as I can tell all the nits mentioned *above* are addressed in the last
version. Enjoy review :-)
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
pspacek commented:
"""
This is rebased and fixed version. It should work including linters. Missing
things:
- [x] use fresh gettext files generated by autoreconf
"""
See
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
pspacek commented:
"""
As far as I can tell all the nits mentioned below are addressed in the last
version. Enjoy review :-)
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
pspacek commented:
"""
This is rebased and fixed version. It should work including linters. Missing
things:
- [ ] use fresh gettext files generated by autoreconf
"""
See
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
lslebodn commented:
"""
and also
```
Making install in po
make[1]: Entering directory '/home/user/freeipa/po'
make[1]: *** No rule to make target 'install'. Stop.
make[1]:
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
mbasti-rh commented:
"""
Lint failed
```
cd .; ./makeaci --validate
./makeaci: ipaserver/plugins/dogtag.py:244: ignoring ImportError: No module
named backports_abc
cd .;
12 matches
Mail list logo
