[Freeipa-devel] [freeipa PR#244][comment] Add templating to ipaplatform path [RFC]

2017-01-18 Thread tiran
  URL: https://github.com/freeipa/freeipa/pull/244
Title: #244: Add templating to ipaplatform path [RFC]

tiran commented:
"""
My PoC is a bit too magic and complicated. PR #373 for Debian support comes 
along nicely without additional magic. I'm closing the PR. I'll keep the branch 
around in case we want to tackle the problem in the future.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/244#issuecomment-273437189
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#244][comment] Add templating to ipaplatform path [RFC]

2016-11-22 Thread tiran
  URL: https://github.com/freeipa/freeipa/pull/244
Title: #244: Add templating to ipaplatform path [RFC]

tiran commented:
"""
Please ignore this PR for now. It's not relevant for PyPI packages.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/244#issuecomment-262220179
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#244][comment] Add templating to ipaplatform path [RFC]

2016-11-21 Thread jcholast
  URL: https://github.com/freeipa/freeipa/pull/244
Title: #244: Add templating to ipaplatform path [RFC]

jcholast commented:
"""
Also LGTM.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/244#issuecomment-262162424
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#244][comment] Add templating to ipaplatform path [RFC]

2016-11-21 Thread mbasti-rh
  URL: https://github.com/freeipa/freeipa/pull/244
Title: #244: Add templating to ipaplatform path [RFC]

mbasti-rh commented:
"""
Can you finish this PR? It can be tested and possibly merged
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/244#issuecomment-261997481
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#244][comment] Add templating to ipaplatform path [RFC]

2016-11-16 Thread mbasti-rh
  URL: https://github.com/freeipa/freeipa/pull/244
Title: #244: Add templating to ipaplatform path [RFC]

mbasti-rh commented:
"""


Edit: wrong PR
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/244#issuecomment-260964435
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#244][comment] Add templating to ipaplatform path [RFC]

2016-11-16 Thread mbasti-rh
  URL: https://github.com/freeipa/freeipa/pull/244
Title: #244: Add templating to ipaplatform path [RFC]

mbasti-rh commented:
"""
You have PEP8 error there
```
./ipalib/cli.py:57:1: E402 module level import not at top of file
```
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/244#issuecomment-260964435
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#244][comment] Add templating to ipaplatform path [RFC]

2016-11-16 Thread mbasti-rh
  URL: https://github.com/freeipa/freeipa/pull/244
Title: #244: Add templating to ipaplatform path [RFC]

mbasti-rh commented:
"""
LGTM then, I'll wait for final version for testing
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/244#issuecomment-260944914
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#244][comment] Add templating to ipaplatform path [RFC]

2016-11-16 Thread tiran
  URL: https://github.com/freeipa/freeipa/pull/244
Title: #244: Add templating to ipaplatform path [RFC]

tiran commented:
"""
It's a RFC patch.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/244#issuecomment-260941678
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#244][comment] Add templating to ipaplatform path [RFC]

2016-11-16 Thread mbasti-rh
  URL: https://github.com/freeipa/freeipa/pull/244
Title: #244: Add templating to ipaplatform path [RFC]

mbasti-rh commented:
"""
It has missing ticket
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/244#issuecomment-260937077
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code