URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with pkg_resource.parse_version
martbab commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/2cbaf156045769b54150e4d4c3c1071f164a16fb
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with pkg_resource.parse_version
martbab commented:
"""
LGTM but please add the relevant ticket number into the commit message.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with pkg_resource.parse_version
tiran commented:
"""
@martbab more fun, the doc string of ```verify_client_version``` deviates from
the actual implementation. The code does not implement the minor version check.
URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with pkg_resource.parse_version
tiran commented:
"""
setuptool's version parser does not support slicing. I need to find another
solution for ```verify_client_version()```.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with pkg_resource.parse_version
martbab commented:
"""
It seems that your changes broke IPA upgrade:
```
Done configuring the web interface (httpd).
Applying LDAP updates
Upgrading IPA:
[1/9]: stopping
URL: https://github.com/freeipa/freeipa/pull/254
Title: #254: Replace LooseVersion with pkg_resource.parse_version
tiran commented:
"""
Back to ```parse_version```!
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/254#issuecomment-261886678
--
Manage your subscription for
