[Freeipa-devel] [freeipa PR#258][comment] Break ipaplatform / ipalib import cycle of hell
URL: https://github.com/freeipa/freeipa/pull/258 Title: #258: Break ipaplatform / ipalib import cycle of hell mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/6409abf1a60f3548203e6607a2b157ff72af2c89 """ See the full comment at https://github.com/freeipa/freeipa/pull/258#issuecomment-262801283 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#258][comment] Break ipaplatform / ipalib import cycle of hell
URL: https://github.com/freeipa/freeipa/pull/258 Title: #258: Break ipaplatform / ipalib import cycle of hell jcholast commented: """ I'm OK with it. """ See the full comment at https://github.com/freeipa/freeipa/pull/258#issuecomment-262797665 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#258][comment] Break ipaplatform / ipalib import cycle of hell
URL: https://github.com/freeipa/freeipa/pull/258 Title: #258: Break ipaplatform / ipalib import cycle of hell mbasti-rh commented: """ ACK from me if @jcholast is not against it """ See the full comment at https://github.com/freeipa/freeipa/pull/258#issuecomment-262797034 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#258][comment] Break ipaplatform / ipalib import cycle of hell
URL: https://github.com/freeipa/freeipa/pull/258 Title: #258: Break ipaplatform / ipalib import cycle of hell tiran commented: """ It's no longer a priority, but I still like to fix the imports No matter what the cyclic imports and cross-package dependencies are a mess. A wrong order of imports can trigger an import error. Even with this PR, ipapython.dogtag triggers an import of ipalib.api. In the long run neither ipaplatform nor ipapython should have an import dependency on ipalib or a global ipalib.api object. Instead the API object should be passed. """ See the full comment at https://github.com/freeipa/freeipa/pull/258#issuecomment-262214571 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#258][comment] Break ipaplatform / ipalib import cycle of hell
URL: https://github.com/freeipa/freeipa/pull/258 Title: #258: Break ipaplatform / ipalib import cycle of hell jcholast commented: """ The original code is broken by design IMO. The API object is used only to get the configured service startup timeout and to guess our DS instance name. None of this is platform specific, so I would prefer if we removed this from `ipaplatform` altogether instead of "just" fixing the import issue. Anyway, given that the current plan is to make `ipaclient` _not_ depend on `ipaplatform`, is this change still necessary? """ See the full comment at https://github.com/freeipa/freeipa/pull/258#issuecomment-262161616 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#258][comment] Break ipaplatform / ipalib import cycle of hell
URL: https://github.com/freeipa/freeipa/pull/258 Title: #258: Break ipaplatform / ipalib import cycle of hell mbasti-rh commented: """ LGTM, except the inline comment I made, I'll test it tomorrow """ See the full comment at https://github.com/freeipa/freeipa/pull/258#issuecomment-261995638 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#258][comment] Break ipaplatform / ipalib import cycle of hell
URL: https://github.com/freeipa/freeipa/pull/258 Title: #258: Break ipaplatform / ipalib import cycle of hell tiran commented: """ thx @mbasti-rh . I took care of it. """ See the full comment at https://github.com/freeipa/freeipa/pull/258#issuecomment-261889771 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
