URL: https://github.com/freeipa/freeipa/pull/261 Author: martbab Title: #261: upgrade: do not set HTTP and DS principals explicitly Action: opened
PR body: """ In ipa-server-upgrade, HTTP and DS principals are explicitly constructed from realm, fqdn, and service prefix. This is no neither required nor desirable, since the principal is now a read-only property which constructs the principal name in the same way. https://fedorahosted.org/freeipa/ticket/6500 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/261/head:pr261 git checkout pr261
From a4657323da629ced2d083c132a521ca707a43955 Mon Sep 17 00:00:00 2001 From: Martin Babinsky <mbabi...@redhat.com> Date: Mon, 21 Nov 2016 13:52:57 +0100 Subject: [PATCH] upgrade: do not set HTTP and DS principals explicitly In ipa-server-upgrade, HTTP and DS principals are explicitly constructed from realm, fqdn, and service prefix. This is no neither required nor desirable, since the principal is now a read-only property which constructs the principal name in the same way. https://fedorahosted.org/freeipa/ticket/6500 --- ipaserver/install/server/upgrade.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/ipaserver/install/server/upgrade.py b/ipaserver/install/server/upgrade.py index 5f61015..d93b908 100644 --- a/ipaserver/install/server/upgrade.py +++ b/ipaserver/install/server/upgrade.py @@ -1589,7 +1589,6 @@ def upgrade_configuration(): http = httpinstance.HTTPInstance(fstore) http.fqdn = fqdn http.realm = api.env.realm - http.principal = "HTTP/%s@%s" % (http.fqdn, http.realm) http.configure_selinux_for_httpd() http.change_mod_nss_port_from_http() @@ -1612,7 +1611,6 @@ def upgrade_configuration(): ds.fqdn = fqdn ds.realm = api.env.realm ds.suffix = ipautil.realm_to_suffix(api.env.realm) - ds.principal = "ldap/%s@%s" % (ds.fqdn, ds.realm) ds_enable_sidgen_extdom_plugins(ds)
-- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code