[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/b7d70baee73c64898de91e2fa59b3f9f417c8e01 https://fedorahosted.org/freeipa/changeset/21a0987601dc4fa9de3fe63a18a604337a5edb7b https://fedorahosted.org/freeipa/changeset/9c87c39e65547004031284080749bc66dab1a8f9 """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-266739980 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ I've found the root cause - incorrect order of operations in freeipa.spec.in. Now it should work. """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-266471594 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
martbab commented:
"""
Yep, running `ipa ping` on Fedora 25 confirms this:
```
# ipa ping
ipa: ERROR: AttributeError: 'str' object has no attribute 'decode'
Traceback (most recent call last):
File "/usr/lib/python3.5/site-packages/ipaclient/remote_plugins/__init__.py",
line 109, in get_package
plugins = api._remote_plugins
AttributeError: 'API' object has no attribute '_remote_plugins'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/lib/python3.5/site-packages/ipalib/cli.py", line 1348, in run
api.finalize()
File "/usr/lib/python3.5/site-packages/ipalib/plugable.py", line 714, in
finalize
self.__do_if_not_done('load_plugins')
File "/usr/lib/python3.5/site-packages/ipalib/plugable.py", line 421, in
__do_if_not_done
getattr(self, name)()
File "/usr/lib/python3.5/site-packages/ipalib/plugable.py", line 592, in
load_plugins
for package in self.packages:
File "/usr/lib/python3.5/site-packages/ipalib/__init__.py", line 919, in
packages
ipaclient.remote_plugins.get_package(self),
File "/usr/lib/python3.5/site-packages/ipaclient/remote_plugins/__init__.py",
line 111, in get_package
server_info = ServerInfo(api)
File "/usr/lib/python3.5/site-packages/ipaclient/remote_plugins/__init__.py",
line 25, in __init__
hostname = DNSName(api.env.server).ToASCII()
File "/usr/lib/python3.5/site-packages/ipapython/dnsutil.py", line 74, in
ToASCII
return self.to_text().decode('ascii') # must be unicode string
AttributeError: 'str' object has no attribute 'decode'
ipa: ERROR: an internal error has occurred
```
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/272#issuecomment-266018649
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time martbab commented: """ I have re-built RPMs in the F25 image and found out that the /usr/bin/ipa command has the following shebang: ``` #!/usr/bin/python3 ``` so this one is the culprit. `ipa-run-tests` has python2 shebang. Keep in mind that before running tests `ipa ping` is called to a) test the functionality of the installation and b) to prepare ~/.ipa directory for tests. I can remove this call if needed but IMHO it is a bug. """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-266017423 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ To be sure I re-built RPMs from this PR using `makerpms.sh` script. My findings are: - `/usr/bin/ipa-run-tests` is a symlink to `/usr/bin/ipa-run-tests-2.7` - `/usr/bin/ipa-run-tests-2.7` has shebang `#!/usr/bin/python2` I have no idea why it should fail in Travis. """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-266016360 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ @martbab Yes for this PR travis run tests under PY3, see tracebacks it is from python3.5 site-packages """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-266009384 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ @martbab Yes for this PR travis run tests under PY3, see tracebacks it is from python3.5 site-packages """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-266009384 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ Relevant parts of SPEC file are here: https://github.com/freeipa/freeipa/pull/272/commits/684f4f5d4fbcfc62c555f7ef856dc2da467cd40c#diff-021f8f69d8c0598dcead3341b439283aR778 """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-266009162 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ `make install` will install whatever is auto-detected during configure (or overriden by `$PYTHON` variable while calling `make install`). So, how are you caling the stuff? If you want to always run Python 2 tests, specify `PYTHON=/usr/bin/python2`. """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-266008502 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time martbab commented: """ Travis installs the built RPMs and then runs server install and outoftree test suite. It does not use `make install`. BTW does this mean that Travis is actually running tests using Py3? Sorry but I am just trying to get up to speed. """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-266008067 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ `make install` put `#!/usr/bin/python` into `ipa-run-tests` and it causes that on F25 our tests are running by default under PY3 Probably travis tests uses make install (haven't looked) """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-266006874 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ @martbab Can I do something in the build system to make your CI implementation easier? """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-265990053 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ ACK, but travis runs tests under PY3 and should be, I tried locally and tests works for me (ipa-run-tests is still py2 by default), so there is an issue with travis tests. I prefer to fix travis first before pushing this to not blocking tests for other PRs. """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-265976899 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ ACK, but travis runs tests under PY3 and should be, I tried locally and tests works for me (ipa-run-tests is still py2 by default), so there is an issue with travis tests. I prefer to fix travis first before pushing this to not blocking tests for other PRs. """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-265976899 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ I've synchronized `python-cryptography` and `python-gssapi` versions. Thank you for noticing. Let's see if CI tests pass or not. """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-265726303 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time tiran commented: """ * CI is failing: ```12-08 10:53 ipadocker.cli ERRORCommand echo Secret123 | kinit admin && ipa ping failed (exit code 1)```. I have kicked Travis. Let's see if the problem persists. * please sync the version requirements of python3-cryptography and python3-gssapi with Python 2 versions. * Regarding your workaround and setuptools comment: I have been meaning to move all scripts to setuptools' entry points for a while. Setuptools only supports one script directory, which defaults to PREFIX/bin. I need to come up with a workaround. But that's a topic for another PR. """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-265721361 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ I've implemented tiran's proposal and rebased the patchset. """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-265708628 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ I'm fine with `make pylint PYTHON=python3` as long as you can agree on it :-) """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-265698399 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ Ok if Petr agree we can go with your proposal """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-265481358 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time tiran commented: """ PS: I'd rather not run both linters in parallel. We use pylint in parallel mode, which runs as many workers as CPU cores. ```make pylint``` already uses up 90-100% CPU cycles on all cores. """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-265480425 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time tiran commented: """ It's easily possible with my proposal, just saying: ```make pylint PYTHON=python3``` ```make pylint PYTHON=python2``` """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-265479049 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ I had discussion with Petr, and currently we cannot run both pylints in build system and it is not easy to add it there. So we have to manually override pylint versions in travis tests, so I would stay with the current version of commits """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-265477567 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ Or we can run both pylints as far as we wants py2/3 compatible versions """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-265472634 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ But we build both 2/3 versions at once """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-265469455 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time tiran commented: """ It makes more sense to follow the principal *test what you build, build what you test*. """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-265460797 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ I would like rather explicit pylint version than autodetection """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-265392287 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time tiran commented: """ +1 for my trick Since I disabled the import warnings for samba bindings in fef6f18aa, pylint is passing under Python 3, too. """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-263954366 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ @mbasti-rh @jcholast @tiran If you want I can replace the `--with-pytlint` option with `--enable-pylint` option (without parameters) and use cheimes's trick with `$(PYTHON) -m pylint` so the Pylint always follows the Python version you used for particular build. Up to you. (Just keep in mind that build needs to be done under Python 2 till samba-python bindings are ported to Python 3.) """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-263868961 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ Fixed. Now `with_pylint` section contains nested section `with_python3`. """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-263868364 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ Shouldn't be there python3 in BuildRequires as well? At least with python3-pylint we need python3 dependencies to be able do pylint3 validation """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-263269939 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time tiran commented: """ AFAIK the build won't run pylint twice with the correct Python version. You could replace the configure option for pylint and the pylint command with: ``` $(PYTHON) -m pylint ``` """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-262817204 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
