URL: https://github.com/freeipa/freeipa/pull/285
Title: #285: Check the result of cert request in replica installer
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/dbb98765d73519289ee22f3de1a5ccde140f6f5d
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/285
Title: #285: Check the result of cert request in replica installer
mbasti-rh commented:
"""
LGTM
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/285#issuecomment-263870742
--
Manage your subscription for the Freeipa-devel
URL: https://github.com/freeipa/freeipa/pull/285
Title: #285: Check the result of cert request in replica installer
flo-renaud commented:
"""
Thanks for the suggestion. I added certmonger's request status in the exception
message.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/285
Title: #285: Check the result of cert request in replica installer
tomaskrizek commented:
"""
Functional ACK. If it's possible, it would be nice to have a bit more info in
the error msg as @mbasti-rh pointed out.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/285
Title: #285: Check the result of cert request in replica installer
mbasti-rh commented:
"""
Can we add cert state to error message? `raise RuntimeError("Certificate
issuance failed")` is not too much detailed in `request_and_wait_for_cert`.