[Freeipa-devel] [freeipa PR#29] Enable LDAPS in replica promotion (comment)

2016-08-29 Thread jcholast
jcholast commented on a pull request

"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/89de60c5d8ba64d619101a7498b8c4469b6e50ae
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/29#issuecomment-243343065
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#29] Enable LDAPS in replica promotion (comment)

2016-08-29 Thread simo5
simo5 commented on a pull request

"""
LGTM
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/29#issuecomment-243174342
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#29] Enable LDAPS in replica promotion (comment)

2016-08-29 Thread tomaskrizek
tomaskrizek commented on a pull request

"""
I've updated the PR based on the comments, please review.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/29#issuecomment-243164916
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#29] Enable LDAPS in replica promotion (comment)

2016-08-29 Thread simo5
simo5 commented on a pull request

"""
That said we should probably enable_ssl righ tafter we get the cert and restart 
DS, and not in replicainstall.py

"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/29#issuecomment-243156343
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#29] Enable LDAPS in replica promotion (comment)

2016-08-29 Thread simo5
simo5 commented on a pull request

"""
@jcholast we can't enable ssl there as the cert is not available yet, look a 
few lines later:
https://github.com/freeipa/freeipa/blob/master/ipaserver/install/dsinstance.py#L397
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/29#issuecomment-243155959
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#29] Enable LDAPS in replica promotion (comment)

2016-08-29 Thread tomaskrizek
tomaskrizek commented on a pull request

"""
@jcholast I'm not certain that enabling the LDAPS before replica promotion 
finishes won't have some unintended side effects.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/29#issuecomment-243152442
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#29] Enable LDAPS in replica promotion (comment)

2016-08-29 Thread tomaskrizek
tomaskrizek commented on a pull request

"""
@jcholast I'm not certain that enabling the LDAPS before replication finishes 
won't have some unintended side effects.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/29#issuecomment-243152442
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#29] Enable LDAPS in replica promotion (comment)

2016-08-28 Thread jcholast
jcholast commented on a pull request

"""
LDAPS is not enabled during replica promotion because of this condition in DS 
setup:

https://github.com/freeipa/freeipa/blob/master/ipaserver/install/dsinstance.py#L391

Maybe we can remove the condition rather than add `ds.enable_ssl()`?
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/29#issuecomment-243039841
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code