URL: https://github.com/freeipa/freeipa/pull/330 Author: pspacek Title: #330: Build: forbid builds in working directories containing white spaces Action: opened
PR body: """ Spaces are causing problems in libtool, makefiles, autoconf itself, gettextize framework etc. so this issue cannot be easily fixed. Return on investment is too small to invest into this. Let's detect the whitespace early and error out with descriptive error message. https://fedorahosted.org/freeipa/ticket/6537 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/330/head:pr330 git checkout pr330
From bdd0bdb27b21ce0c1c4ce58ea59e8dbedb77f403 Mon Sep 17 00:00:00 2001 From: Petr Spacek <pspa...@redhat.com> Date: Tue, 13 Dec 2016 10:52:46 +0100 Subject: [PATCH] Build: forbid builds in working directories containing white spaces Spaces are causing problems in libtool, makefiles, autoconf itself, gettextize framework etc. so this issue cannot be easily fixed. Return on investment is too small to invest into this. Let's detect the whitespace early and error out with descriptive error message. https://fedorahosted.org/freeipa/ticket/6537 --- configure.ac | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/configure.ac b/configure.ac index c02a672..9bf72a2 100644 --- a/configure.ac +++ b/configure.ac @@ -5,6 +5,14 @@ AC_INIT([freeipa], IPA_VERSION, [https://hosted.fedoraproject.org/projects/freeipa/newticket]) +dnl Make sure the build directory name does not contain spaces! +dnl Spaces are causing problems in libtool, makefiles, autoconf itself, +dnl gettextize framework etc. +case "$PWD" in + *\ * | *\ *) + AC_MSG_ERROR([whitespace in working directory path is not supported]) ;; +esac + AC_CONFIG_HEADERS([config.h]) AM_INIT_AUTOMAKE([foreign 1.9 tar-ustar])
-- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
