URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
HonzaCholasta commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/10ef5947860f5098182b1f95c08c1158e2da15f9
URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
LiptonB commented:
"""
@HonzaCholasta, updated, please take a look. I standardized on "CSR generation
profile" because the names of the objects in the code and the directory that
stores them
URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
HonzaCholasta commented:
"""
Before I push this, could you please:
* squash "Fix broken tests in CSR autogeneration" into "Add tests for CSR
autogeneration",
* add module prefix to commit
URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
HonzaCholasta commented:
"""
@LiptonB, I meant it the other way around - `certprofile` should have an
(optional) attribute which points to the associated CSR template.
"""
See the full
URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
LiptonB commented:
"""
@HonzaCholasta, I think we're on the same page, then. I removed the dogtag
profile and the validation from the `profile_id` parameter, and rebased the PR
against
URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
HonzaCholasta commented:
"""
@LiptonB, I think certificate profiles and CSR generation profiles / templates
*should* be associated, but not by sharing the same logical `certprofile`
object,
URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
LiptonB commented:
"""
@HonzaCholasta, I think I see what you mean about these templates not being
dependent on dogtag, and I'm fine with removing the `userCert` dogtag profile
from this PR
URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
HonzaCholasta commented:
"""
@LiptonB, there's still one issue which I'd like to be resolved in this PR, and
that's that currently CSR templates are tied to certificate profiles. IMO this
URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
tiran commented:
"""
@LiptonB yes, it's correct.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/337#issuecomment-273705203
--
Manage your subscription for the
URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
LiptonB commented:
"""
@tiran Thanks to the team for resuming the review, too! Added the dependency,
does that look right?
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
tiran commented:
"""
@LiptonB thanks a lot for resuming your work!
Please add jinja2 to ``` ipaclient/setup.py```, too.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
martbab commented:
"""
From Travis CI logs it looks like a correct branch was fetched this time.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/337#issuecomment-267069024
12 matches
Mail list logo